Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-14 Thread Amit Kucheria
On Sat, Jan 12, 2019 at 2:06 AM Matthias Kaehlcke wrote: > > Another concern about adding trip points later could be the node > name. We currently have: > > > trips { > cpu0_alert0: trip0 { > ... > }; > > cpu0_crit: trip1 { > ... > }; > }; > > If we keep increasing enumeration with

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-13 Thread Viresh Kumar
On 11-01-19, 11:58, Matthias Kaehlcke wrote: > On Fri, Jan 11, 2019 at 09:16:53AM +0530, Viresh Kumar wrote: > Just to gain a better understanding: is cpuidle cooling already > available for arm64 (or is there a patch set)? I came across the > relatively new idle injecting framework but it seems cu

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-11 Thread Matthias Kaehlcke
On Fri, Jan 11, 2019 at 04:47:15PM +0530, Amit Kucheria wrote: > On Fri, Jan 11, 2019 at 6:00 AM Matthias Kaehlcke wrote: > > > > On Thu, Jan 10, 2019 at 05:30:56AM +0530, Amit Kucheria wrote: > > > Since the big and little cpus are in the same frequency domain, use all > > > of them for mitigatio

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-11 Thread Matthias Kaehlcke
On Fri, Jan 11, 2019 at 09:16:53AM +0530, Viresh Kumar wrote: > On 10-01-19, 10:42, Matthias Kaehlcke wrote: > > Thanks for the pointer, there's always something new to learn! > > > > Ok, so the policy CPU and hence the CPU registered as cooling > > device may vary. I understand that this requires

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-11 Thread Amit Kucheria
On Fri, Jan 11, 2019 at 6:00 AM Matthias Kaehlcke wrote: > > On Thu, Jan 10, 2019 at 05:30:56AM +0530, Amit Kucheria wrote: > > Since the big and little cpus are in the same frequency domain, use all > > of them for mitigation in the cooling-map. At the lower trip points we > > restrict ourselves

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-10 Thread Viresh Kumar
On 10-01-19, 10:42, Matthias Kaehlcke wrote: > Thanks for the pointer, there's always something new to learn! > > Ok, so the policy CPU and hence the CPU registered as cooling > device may vary. I understand that this requires to list all possible > cooling devices, I won't say that I changed DT

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-10 Thread Matthias Kaehlcke
On Thu, Jan 10, 2019 at 05:30:56AM +0530, Amit Kucheria wrote: > Since the big and little cpus are in the same frequency domain, use all > of them for mitigation in the cooling-map. At the lower trip points we > restrict ourselves to throttling only a few OPPs. At higher trip > temperatures, allow

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-10 Thread Matthias Kaehlcke
On Thu, Jan 10, 2019 at 11:53:59AM +0530, Viresh Kumar wrote: > On 09-01-19, 18:22, Matthias Kaehlcke wrote: > > Hi Amit, > > > > On Thu, Jan 10, 2019 at 05:30:56AM +0530, Amit Kucheria wrote: > > > Since the big and little cpus are in the same frequency domain, use all > > > of them for mitigatio

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-10 Thread Amit Kucheria
On Thu, Jan 10, 2019 at 5:58 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-01-09 16:00:56) > > Since the big and little cpus are in the same frequency domain, use all > > Oh? I thought the big and little cpus were in different frequency > domains and voltage domains. Maybe that's what you

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-09 Thread Viresh Kumar
On 09-01-19, 18:22, Matthias Kaehlcke wrote: > Hi Amit, > > On Thu, Jan 10, 2019 at 05:30:56AM +0530, Amit Kucheria wrote: > > Since the big and little cpus are in the same frequency domain, use all > > of them for mitigation in the cooling-map. At the lower trip points we > > restrict ourselves t

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-09 Thread Matthias Kaehlcke
Hi Amit, On Thu, Jan 10, 2019 at 05:30:56AM +0530, Amit Kucheria wrote: > Since the big and little cpus are in the same frequency domain, use all > of them for mitigation in the cooling-map. At the lower trip points we > restrict ourselves to throttling only a few OPPs. At higher trip > temperatur

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-09 Thread Stephen Boyd
Quoting Amit Kucheria (2019-01-09 16:00:56) > Since the big and little cpus are in the same frequency domain, use all Oh? I thought the big and little cpus were in different frequency domains and voltage domains. Maybe that's what you're saying here but I'm misunderstanding. So change the wording

[PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-09 Thread Amit Kucheria
Since the big and little cpus are in the same frequency domain, use all of them for mitigation in the cooling-map. At the lower trip points we restrict ourselves to throttling only a few OPPs. At higher trip temperatures, allow ourselves to be throttled to any extent. Signed-off-by: Amit Kucheria