Re: [PATCH v1 5/9] perf util: Remove a set of shadow stats static variables

2017-11-21 Thread Jiri Olsa
On Tue, Nov 21, 2017 at 10:03:50AM -0800, Andi Kleen wrote: > > all this is about switching from array to rb_list for the --per-thread case, > > which can be considered as a special use case.. how much do we suffer in > > performance with new code? how about the "perf stat -I 100", would it scale >

Re: [PATCH v1 5/9] perf util: Remove a set of shadow stats static variables

2017-11-21 Thread Andi Kleen
> all this is about switching from array to rb_list for the --per-thread case, > which can be considered as a special use case.. how much do we suffer in > performance with new code? how about the "perf stat -I 100", would it scale > ok for extreme cases (many events in -e or -..) rbtrees scal

Re: [PATCH v1 5/9] perf util: Remove a set of shadow stats static variables

2017-11-21 Thread Jiri Olsa
On Mon, Nov 20, 2017 at 10:43:40PM +0800, Jin Yao wrote: > In previous patches, we have reconstructed the code and let > it not access the static variables directly. > > This patch removes these static variables. > > Signed-off-by: Jin Yao > --- > tools/perf/util/stat-shadow.c | 64 > +

[PATCH v1 5/9] perf util: Remove a set of shadow stats static variables

2017-11-19 Thread Jin Yao
In previous patches, we have reconstructed the code and let it not access the static variables directly. This patch removes these static variables. Signed-off-by: Jin Yao --- tools/perf/util/stat-shadow.c | 64 ++- tools/perf/util/stat.h| 1 + 2