Re: [PATCH v1 5/6] zram: remove zram_rw_page

2017-08-08 Thread Matthew Wilcox
On Tue, Aug 08, 2017 at 05:23:50PM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (08/08/17 17:13), Minchan Kim wrote: > > Hi Sergey, > > > > On Tue, Aug 08, 2017 at 04:02:26PM +0900, Sergey Senozhatsky wrote: > > > On (08/08/17 15:50), Minchan Kim wrote: > > > > With on-stack-bio, rw_p

Re: [PATCH v1 5/6] zram: remove zram_rw_page

2017-08-08 Thread Sergey Senozhatsky
Hello Minchan, On (08/08/17 17:13), Minchan Kim wrote: > Hi Sergey, > > On Tue, Aug 08, 2017 at 04:02:26PM +0900, Sergey Senozhatsky wrote: > > On (08/08/17 15:50), Minchan Kim wrote: > > > With on-stack-bio, rw_page interface doesn't provide a clear performance > > > benefit for zram and surely

Re: [PATCH v1 5/6] zram: remove zram_rw_page

2017-08-08 Thread Minchan Kim
Hi Sergey, On Tue, Aug 08, 2017 at 04:02:26PM +0900, Sergey Senozhatsky wrote: > On (08/08/17 15:50), Minchan Kim wrote: > > With on-stack-bio, rw_page interface doesn't provide a clear performance > > benefit for zram and surely has a maintenance burden, so remove the > > last user to remove rw_p

Re: [PATCH v1 5/6] zram: remove zram_rw_page

2017-08-08 Thread Sergey Senozhatsky
On (08/08/17 15:50), Minchan Kim wrote: > With on-stack-bio, rw_page interface doesn't provide a clear performance > benefit for zram and surely has a maintenance burden, so remove the > last user to remove rw_page completely. OK, never really liked it, I think we had that conversation before. as

[PATCH v1 5/6] zram: remove zram_rw_page

2017-08-07 Thread Minchan Kim
With on-stack-bio, rw_page interface doesn't provide a clear performance benefit for zram and surely has a maintenance burden, so remove the last user to remove rw_page completely. Cc: Sergey Senozhatsky Signed-off-by: Minchan Kim --- drivers/block/zram/zram_drv.c | 52 -