Re: [PATCH v1 5/6] blk-mq: fix for trace_block_plug()

2015-10-19 Thread Ming Lei
On Tue, Oct 20, 2015 at 1:59 AM, Jeff Moyer wrote: > Ming Lei writes: > >> On Mon, Oct 19, 2015 at 11:38 PM, Jeff Moyer wrote: >>> Ming Lei writes: >>> The trace point is for tracing plug event of each request queue instead of each task, so we should check the request count in th

Re: [PATCH v1 5/6] blk-mq: fix for trace_block_plug()

2015-10-19 Thread Jeff Moyer
Ming Lei writes: > On Mon, Oct 19, 2015 at 11:38 PM, Jeff Moyer wrote: >> Ming Lei writes: >> >>> The trace point is for tracing plug event of each request >>> queue instead of each task, so we should check the request >>> count in the plug list from current queue instead of >>> current task. >

Re: [PATCH v1 5/6] blk-mq: fix for trace_block_plug()

2015-10-19 Thread Ming Lei
On Mon, Oct 19, 2015 at 11:38 PM, Jeff Moyer wrote: > Ming Lei writes: > >> The trace point is for tracing plug event of each request >> queue instead of each task, so we should check the request >> count in the plug list from current queue instead of >> current task. > > If blk_queue_nomerges re

Re: [PATCH v1 5/6] blk-mq: fix for trace_block_plug()

2015-10-19 Thread Jeff Moyer
Ming Lei writes: > The trace point is for tracing plug event of each request > queue instead of each task, so we should check the request > count in the plug list from current queue instead of > current task. If blk_queue_nomerges returns true, request_count won't be updated, so you've essential

[PATCH v1 5/6] blk-mq: fix for trace_block_plug()

2015-10-17 Thread Ming Lei
The trace point is for tracing plug event of each request queue instead of each task, so we should check the request count in the plug list from current queue instead of current task. Signed-off-by: Ming Lei --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/b