Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 04:45:04PM +0930, Rusty Russell wrote: > "Luis R. Rodriguez" writes: > > From: "Luis R. Rodriguez" > > > > This adds a couple of bool module_param_config_*() helpers > > which are designed to let us easily associate a booloean > > module parameter with an associated kernel

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-22 Thread Rusty Russell
"Luis R. Rodriguez" writes: > From: "Luis R. Rodriguez" > > This adds a couple of bool module_param_config_*() helpers > which are designed to let us easily associate a booloean > module parameter with an associated kernel configuration > option, and to help us remove #ifdef'ery eyesores. But th

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-21 Thread Tejun Heo
Hello, Luis. On Tue, Apr 21, 2015 at 06:55:16PM +0200, Luis R. Rodriguez wrote: > A use then would be for instance: > > module_param_config_on_off(power_efficient, wq_power_efficient, 0444, > IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT)); > > this as an alternative woul

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 11:21:36AM -0400, Tejun Heo wrote: > On Mon, Apr 20, 2015 at 04:30:35PM -0700, Luis R. Rodriguez wrote: > > /** > > + * module_param_config_on_off - bool parameter with run time override > > + * @name: a valid C identifier which is the parameter name. > > + * @value: the ac

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 09:42:21AM +1000, Julian Calaby wrote: > Hi Luis, > > You made a spelling mistake: > > On Tue, Apr 21, 2015 at 9:30 AM, Luis R. Rodriguez > wrote: > > From: "Luis R. Rodriguez" > > > > This adds a couple of bool module_param_config_*() helpers > > which are designed to l

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-21 Thread Tejun Heo
On Mon, Apr 20, 2015 at 04:30:35PM -0700, Luis R. Rodriguez wrote: > /** > + * module_param_config_on_off - bool parameter with run time override > + * @name: a valid C identifier which is the parameter name. > + * @value: the actual lvalue to alter. > + * @perm: visibility in sysfs. > + * @config

Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-20 Thread Julian Calaby
Hi Luis, You made a spelling mistake: On Tue, Apr 21, 2015 at 9:30 AM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This adds a couple of bool module_param_config_*() helpers > which are designed to let us easily associate a booloean > module parameter with an associated kernel conf

[PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers

2015-04-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This adds a couple of bool module_param_config_*() helpers which are designed to let us easily associate a booloean module parameter with an associated kernel configuration option, and to help us remove #ifdef'ery eyesores. Cc: Rusty Russell Cc: Jani Nikula Cc: Christ