Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch

2019-10-17 Thread Oleksij Rempel
On Thu, Oct 17, 2019 at 11:35:48AM -0700, Florian Fainelli wrote: > > > On 10/13/2019 11:15 PM, Oleksij Rempel wrote: > > Provide basic support for Atheros AR9331 build-in switch. So far it > > works as port multiplexer without any hardware offloading support. > > I glanced through the functiona

Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch

2019-10-17 Thread Florian Fainelli
On 10/13/2019 11:15 PM, Oleksij Rempel wrote: > Provide basic support for Atheros AR9331 build-in switch. So far it > works as port multiplexer without any hardware offloading support. I glanced through the functional parts of the code, and it looks pretty straight forward, since there is no of

Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch

2019-10-16 Thread Fabio Estevam
On Wed, Oct 16, 2019 at 1:01 PM Andrew Lunn wrote: > I think C files should use /* */, and header files //, for SPDX. Not really. >From Documentation/process/license-rules.rst: "C source: // SPDX-License-Identifier: C header: /* SPDX-License-Identifier: */ "

Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch

2019-10-16 Thread Oleksij Rempel
On Wed, Oct 16, 2019 at 03:00:57PM +0200, Andrew Lunn wrote: > > +++ b/drivers/net/dsa/qca/ar9331.c > > @@ -0,0 +1,822 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > I think C files should use /* */, and header files //, for SPDX. OK. In fact, there are both variants present in Kernel. I'l

Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch

2019-10-16 Thread Andrew Lunn
> +++ b/drivers/net/dsa/qca/ar9331.c > @@ -0,0 +1,822 @@ > +// SPDX-License-Identifier: GPL-2.0-only I think C files should use /* */, and header files //, for SPDX. > +// Copyright (c) 2019 Pengutronix, Oleksij Rempel > + > +#include > +#include > +#include > +#include > +#include > +#inc

[PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch

2019-10-13 Thread Oleksij Rempel
Provide basic support for Atheros AR9331 build-in switch. So far it works as port multiplexer without any hardware offloading support. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/Kconfig | 2 + drivers/net/dsa/Makefile | 1 + drivers/net/dsa/qca/Kconfig | 11 + drivers/net/d