Re: [PATCH v1 2/2] Add PWM driver for LGM

2020-05-27 Thread Tanwar, Rahul
On 27/5/2020 5:15 pm, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 02:28:53PM +0800, Tanwar, Rahul wrote: >> On 22/5/2020 4:56 pm, Uwe Kleine-König wrote: >>> On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: > ... > >>> I'm a unhappy to have this in the PWM driver. The PWM driver

Re: [PATCH v1 2/2] Add PWM driver for LGM

2020-05-27 Thread Andy Shevchenko
On Wed, May 27, 2020 at 02:28:53PM +0800, Tanwar, Rahul wrote: > On 22/5/2020 4:56 pm, Uwe Kleine-König wrote: > > On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: ... > > I'm a unhappy to have this in the PWM driver. The PWM driver is supposed > > to be generic and I think this belo

Re: [PATCH v1 2/2] Add PWM driver for LGM

2020-05-26 Thread Tanwar, Rahul
Hi Uwe, Thanks for review. On 22/5/2020 4:56 pm, Uwe Kleine-König wrote: > Hello, > > On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: >> Add PWM controller driver for Intel's Lightning Mountain(LGM) SoC. >> >> Signed-off-by: Rahul Tanwar >> --- >> drivers/pwm/Kconfig |

Re: [PATCH v1 2/2] Add PWM driver for LGM

2020-05-22 Thread Uwe Kleine-König
Hello Andy, On Fri, May 22, 2020 at 12:18:24PM +0300, Andy Shevchenko wrote: > On Fri, May 22, 2020 at 10:56:13AM +0200, Uwe Kleine-König wrote: > > On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: > > > > + io_base = devm_platform_ioremap_resource(pdev, 0); > > > + if (IS_ERR(io_bas

Re: [PATCH v1 2/2] Add PWM driver for LGM

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 10:56:13AM +0200, Uwe Kleine-König wrote: > On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: > > + io_base = devm_platform_ioremap_resource(pdev, 0); > > + if (IS_ERR(io_base)) > > error message here? platform core provides it. No need to duplicate (esp.

Re: [PATCH v1 2/2] Add PWM driver for LGM

2020-05-22 Thread Uwe Kleine-König
Hello, On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: > Add PWM controller driver for Intel's Lightning Mountain(LGM) SoC. > > Signed-off-by: Rahul Tanwar > --- > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile| 1 + > drivers/pwm/pwm-intel-lgm.c | 356 > +

[PATCH v1 2/2] Add PWM driver for LGM

2020-05-22 Thread Rahul Tanwar
Add PWM controller driver for Intel's Lightning Mountain(LGM) SoC. Signed-off-by: Rahul Tanwar --- drivers/pwm/Kconfig | 9 ++ drivers/pwm/Makefile| 1 + drivers/pwm/pwm-intel-lgm.c | 356 3 files changed, 366 insertions(+) create