Re: [PATCH v1 11/19] x86/sev-es: Convert to insn_decode()

2021-01-21 Thread Sean Christopherson
On Thu, Jan 21, 2021, Borislav Petkov wrote: > On Mon, Dec 28, 2020 at 11:15:11AM -0800, Sean Christopherson wrote: > > Alternatively, could the kernel case use insn_decode_regs()? If > > vc_fetch_insn_kernel() were also modified to mirror insn_fetch_from_user(), > > the > > two code paths could

Re: [PATCH v1 11/19] x86/sev-es: Convert to insn_decode()

2021-01-21 Thread Borislav Petkov
On Mon, Dec 28, 2020 at 11:15:11AM -0800, Sean Christopherson wrote: > Alternatively, could the kernel case use insn_decode_regs()? If > vc_fetch_insn_kernel() were also modified to mirror insn_fetch_from_user(), > the > two code paths could be unified except for the the fetch and the PFEC. E.g.

Re: [PATCH v1 11/19] x86/sev-es: Convert to insn_decode()

2020-12-28 Thread Sean Christopherson
On Fri, Dec 25, 2020, Borislav Petkov wrote: > On Fri, Dec 25, 2020 at 06:50:33PM +0800, kernel test robot wrote: > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> arch/x86/kernel/sev-es

Re: [PATCH v1 11/19] x86/sev-es: Convert to insn_decode()

2020-12-25 Thread Borislav Petkov
On Fri, Dec 25, 2020 at 06:50:33PM +0800, kernel test robot wrote: > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> arch/x86/kernel/sev-es.c:258:7: warning: variable 'ret' is used > >> uninitializ

Re: [PATCH v1 11/19] x86/sev-es: Convert to insn_decode()

2020-12-25 Thread kernel test robot
Hi Borislav, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10 next-20201223] [cannot apply to tip/perf/core tip/x86/core luto/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

[PATCH v1 11/19] x86/sev-es: Convert to insn_decode()

2020-12-23 Thread Borislav Petkov
From: Borislav Petkov Simplify code, no functional changes. Signed-off-by: Borislav Petkov --- arch/x86/kernel/sev-es.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/sev-es.c b/arch/x86/kernel/sev-es.c index 37736486603e..564cc9fc693d 100644