Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages

2018-08-30 Thread Pasha Tatashin
On 8/30/18 4:17 PM, Pasha Tatashin wrote: > I guess the wrap was done because of __ref, but no reason to have this > wrap. So looks good to me. > > Reviewed-by: Pavel Tatashin > > On 8/16/18 6:06 AM, David Hildenbrand wrote: >> Let's avoid this indirection and just call the function offline_page

Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages

2018-08-30 Thread Pasha Tatashin
I guess the wrap was done because of __ref, but no reason to have this wrap. So looks good to me. Reviewed-by: Pavel Tatashin On 8/16/18 6:06 AM, David Hildenbrand wrote: > Let's avoid this indirection and just call the function offline_pages(). > > Signed-off-by: David Hildenbrand > --- > mm

Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages

2018-08-16 Thread kbuild test robot
Hi David, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.18 next-20180816] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages

2018-08-16 Thread David Hildenbrand
On 16.08.2018 13:44, Stephen Rothwell wrote: > Hi David, > > On Thu, 16 Aug 2018 12:06:24 +0200 David Hildenbrand wrote: >> >> -static int __ref __offline_pages(unsigned long start_pfn, >> - unsigned long end_pfn) >> +/* Must be protected by mem_hotplug_begin() or a device_lock */ >>

Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages

2018-08-16 Thread Stephen Rothwell
Hi David, On Thu, 16 Aug 2018 12:06:24 +0200 David Hildenbrand wrote: > > -static int __ref __offline_pages(unsigned long start_pfn, > - unsigned long end_pfn) > +/* Must be protected by mem_hotplug_begin() or a device_lock */ > +int offline_pages(unsigned long start_pfn, unsigned l

[PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages

2018-08-16 Thread David Hildenbrand
Let's avoid this indirection and just call the function offline_pages(). Signed-off-by: David Hildenbrand --- mm/memory_hotplug.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 6a2726920ed2..090cf474de87 100644 -