Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-26 Thread Sam Ravnborg
On Wed, Sep 26, 2018 at 08:51:21PM +0200, Alexandre Belloni wrote: > On 26/09/2018 10:47:08-0500, Rob Herring wrote: > > > > +Optional property: > > > > +- nxp,quartz_load_12.5pF: The capacitive load on the quartz is 12.5 pF, > > > > + which differ from the default value of 7 pF > > > > + > > > >

Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-26 Thread Alexandre Belloni
On 26/09/2018 10:47:08-0500, Rob Herring wrote: > > > +Optional property: > > > +- nxp,quartz_load_12.5pF: The capacitive load on the quartz is 12.5 pF, > > > + which differ from the default value of 7 pF > > > + > > > > The boolean properties usually don't work well for RTCs because people > > u

Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-26 Thread Rob Herring
On Thu, Sep 13, 2018 at 09:05:16PM +0200, Alexandre Belloni wrote: > Hi, > > You can remove 'rtci-' from the subject. > > On 07/09/2018 21:35:04+0200, Sam Ravnborg wrote: > > From: Søren Andersen > > > > The NXP pcf8523 supports two different quartz loads. > > - 7 pF (default) > > - 12.5 pF (mi

Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-13 Thread Alexandre Belloni
On 13/09/2018 22:44:12+0200, Sam Ravnborg wrote: > > The boolean properties usually don't work well for RTCs because people > > usually want to keep any previous configuration that may have been done > > at the factory or in the bootloader so I would use: > > > > nxp,quartz_load_fF and this would

Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-13 Thread Sam Ravnborg
Hi Alexandre. On Thu, Sep 13, 2018 at 09:05:16PM +0200, Alexandre Belloni wrote: > Hi, > > You can remove 'rtci-' from the subject. The 'i' part was me fooling around in vi. After submitting this serie I read the proper subject would be: (from bindings/submitting-patches.txt) dt-bindings: rtc:

Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-13 Thread Alexandre Belloni
Hi, You can remove 'rtci-' from the subject. On 07/09/2018 21:35:04+0200, Sam Ravnborg wrote: > From: Søren Andersen > > The NXP pcf8523 supports two different quartz loads. > - 7 pF (default) > - 12.5 pF (minimum power consumption) > > The pcf8523 needs to know the size of the quartz load, >

Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-07 Thread Sam Ravnborg
Hi all. > +Optional property: > +- nxp,quartz_load_12.5pF: The capacitive load on the quartz is 12.5 pF, > + which differ from the default value of 7 pF > + > +Example: > + > +pcf8523: pcf8523@68 { > + compatible = "nxp,pcf85063"; > + reg = <0x68>; > + nxp,quartz_load_12.5pF; > +}; T

[PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property

2018-09-07 Thread Sam Ravnborg
From: Søren Andersen The NXP pcf8523 supports two different quartz loads. - 7 pF (default) - 12.5 pF (minimum power consumption) The pcf8523 needs to know the size of the quartz load, otherwise the the RTC will have a bad precision. The default for the rtc (after power-on) is 7 pF. Add a proper