Re: [PATCH v1 1/5] block: blk-mq: avoid initializing request during its completion

2013-12-31 Thread Ming Lei
Hi Jens, On Wed, Jan 1, 2014 at 12:38 AM, Jens Axboe wrote: > On Thu, Dec 26 2013, Ming Lei wrote: >> One problem is that request->start_time/start_time_ns could be >> set as wrong. >> >> Also it is normal to intialize one data structure just after its >> allocation. >> >> So move the initializat

Re: [PATCH v1 1/5] block: blk-mq: avoid initializing request during its completion

2013-12-31 Thread Jens Axboe
On Thu, Dec 26 2013, Ming Lei wrote: > One problem is that request->start_time/start_time_ns could be > set as wrong. > > Also it is normal to intialize one data structure just after its > allocation. > > So move the initialization out of its completion path. It's done that way because of presum

[PATCH v1 1/5] block: blk-mq: avoid initializing request during its completion

2013-12-26 Thread Ming Lei
One problem is that request->start_time/start_time_ns could be set as wrong. Also it is normal to intialize one data structure just after its allocation. So move the initialization out of its completion path. Cc: Jens Axboe Signed-off-by: Ming Lei --- block/blk-mq.c | 26 +--