Re: [virtio-dev] Re: [PATCH v1 1/2] virtio-balloon: tweak config_changed implementation

2019-01-03 Thread Wei Wang
On 01/04/2019 12:42 AM, Michael S. Tsirkin wrote: On Thu, Jan 03, 2019 at 01:31:01PM +0800, Wei Wang wrote: virtio-ccw has deadlock issues with reading config registers inside the interrupt context, so we tweak the virtballoon_changed implementation by moving the config read operations into the

Re: [PATCH v1 1/2] virtio-balloon: tweak config_changed implementation

2019-01-03 Thread Michael S. Tsirkin
On Thu, Jan 03, 2019 at 01:31:01PM +0800, Wei Wang wrote: > virtio-ccw has deadlock issues with reading config registers inside the > interrupt context, so we tweak the virtballoon_changed implementation > by moving the config read operations into the related workqueue contexts. > > Signed-off-by:

Re: [PATCH v1 1/2] virtio-balloon: tweak config_changed implementation

2019-01-03 Thread Halil Pasic
On Thu, 3 Jan 2019 13:31:01 +0800 Wei Wang wrote: > virtio-ccw has deadlock issues with reading config registers inside the > interrupt context I would say something like 'virtio-ccw does not support using virtio_config_ops from an atomic context' as the limitation is not limited to read config

Re: [PATCH v1 1/2] virtio-balloon: tweak config_changed implementation

2019-01-03 Thread Wei Wang
On 01/03/2019 05:40 PM, Cornelia Huck wrote: On Thu, 3 Jan 2019 13:31:01 +0800 Wei Wang wrote: virtio-ccw has deadlock issues with reading config registers inside the s/config registers/the config space/ ? Sounds good. interrupt context, so we tweak the virtballoon_changed implementati

Re: [PATCH v1 1/2] virtio-balloon: tweak config_changed implementation

2019-01-03 Thread Cornelia Huck
On Thu, 3 Jan 2019 13:31:01 +0800 Wei Wang wrote: > virtio-ccw has deadlock issues with reading config registers inside the s/config registers/the config space/ ? > interrupt context, so we tweak the virtballoon_changed implementation > by moving the config read operations into the related wor

[PATCH v1 1/2] virtio-balloon: tweak config_changed implementation

2019-01-02 Thread Wei Wang
virtio-ccw has deadlock issues with reading config registers inside the interrupt context, so we tweak the virtballoon_changed implementation by moving the config read operations into the related workqueue contexts. Signed-off-by: Wei Wang --- drivers/virtio/virtio_balloon.c | 54 +++