Re: [PATCH v1 1/2] mm: drop vm_total_pages

2020-06-23 Thread Michal Hocko
On Fri 19-06-20 15:24:09, David Hildenbrand wrote: > The global variable "vm_total_pages" is a relict from older days. There > is only a single user that reads the variable - build_all_zonelists() - > and the first thing it does is updating it. Use a local variable in > build_all_zonelists() instea

Re: [PATCH v1 1/2] mm: drop vm_total_pages

2020-06-22 Thread David Hildenbrand
On 21.06.20 16:46, Mike Rapoport wrote: > On Fri, Jun 19, 2020 at 03:24:09PM +0200, David Hildenbrand wrote: >> The global variable "vm_total_pages" is a relict from older days. There >> is only a single user that reads the variable - build_all_zonelists() - >> and the first thing it does is updati

Re: [PATCH v1 1/2] mm: drop vm_total_pages

2020-06-21 Thread Pankaj Gupta
> The global variable "vm_total_pages" is a relict from older days. There > is only a single user that reads the variable - build_all_zonelists() - > and the first thing it does is updating it. Use a local variable in > build_all_zonelists() instead and drop the local variable. > > Cc: Andrew Morto

Re: [PATCH v1 1/2] mm: drop vm_total_pages

2020-06-21 Thread Mike Rapoport
On Fri, Jun 19, 2020 at 03:24:09PM +0200, David Hildenbrand wrote: > The global variable "vm_total_pages" is a relict from older days. There > is only a single user that reads the variable - build_all_zonelists() - > and the first thing it does is updating it. Use a local variable in > build_all_zo

Re: [PATCH v1 1/2] mm: drop vm_total_pages

2020-06-19 Thread Wei Yang
On Fri, Jun 19, 2020 at 03:24:09PM +0200, David Hildenbrand wrote: >The global variable "vm_total_pages" is a relict from older days. There >is only a single user that reads the variable - build_all_zonelists() - >and the first thing it does is updating it. Use a local variable in >build_all_zoneli

[PATCH v1 1/2] mm: drop vm_total_pages

2020-06-19 Thread David Hildenbrand
The global variable "vm_total_pages" is a relict from older days. There is only a single user that reads the variable - build_all_zonelists() - and the first thing it does is updating it. Use a local variable in build_all_zonelists() instead and drop the local variable. Cc: Andrew Morton Cc: Joha