Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early

2013-06-03 Thread Barry Song
hi Srinivas, 2013/6/3 Srinivas KANDAGATLA : > Hi Barry, > Thanks for testing, > I think this patch introduced a sequencing issue. > > Just re-looking at the code, is there any reason for this to be > init_earlycall? And do a ioremap at that early stage? > > Can't we move it to device_init level fu

Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early

2013-06-03 Thread Srinivas KANDAGATLA
Hi Barry, Thanks for testing, I think this patch introduced a sequencing issue. Just re-looking at the code, is there any reason for this to be init_earlycall? And do a ioremap at that early stage? Can't we move it to device_init level function "sirfsoc_mach_init()" at which it will be safe to do

Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early

2013-06-02 Thread Barry Song
hi Srinivas, 2013/5/31 Srinivas KANDAGATLA : > From: Srinivas Kandagatla > > This patch moves sirfsoc_of_rstc_init from early_initcall to .init_early > in machine descriptor, doing this way a multi_v7 kernel will not crash > on non-prima2 SOCs. > > Without this patch the multi_v7 kernel panics if

Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early

2013-05-31 Thread Barry Song
2013/5/31 Srinivas KANDAGATLA : > On 31/05/13 13:24, Barry Song wrote: >>> > Signed-off-by: Srinivas Kandagatla >> hi Sriniva, >> i think my "arm: prima2: move to generic reset controller driver >> framework" fixs this too: >> http://www.spinics.net/lists/arm-kernel/msg246206.html > I did look at

Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early

2013-05-31 Thread Srinivas KANDAGATLA
On 31/05/13 13:24, Barry Song wrote: >> > Signed-off-by: Srinivas Kandagatla > hi Sriniva, > i think my "arm: prima2: move to generic reset controller driver > framework" fixs this too: > http://www.spinics.net/lists/arm-kernel/msg246206.html I did look at the patch, I think it will fix it. But t

Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early

2013-05-31 Thread Barry Song
2013/5/31 Srinivas KANDAGATLA : > From: Srinivas Kandagatla > > This patch moves sirfsoc_of_rstc_init from early_initcall to .init_early > in machine descriptor, doing this way a multi_v7 kernel will not crash > on non-prima2 SOCs. > > Without this patch the multi_v7 kernel panics if we boot it on

[PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early

2013-05-31 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch moves sirfsoc_of_rstc_init from early_initcall to .init_early in machine descriptor, doing this way a multi_v7 kernel will not crash on non-prima2 SOCs. Without this patch the multi_v7 kernel panics if we boot it on any non prima2 parts with below log: Kerne