Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 07, 2021 at 10:43:53AM -0600, Jens Axboe wrote: > On 4/7/21 10:27 AM, Andy Shevchenko wrote: > > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: > >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: > >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > > >

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Jens Axboe
On 4/7/21 10:27 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > ... > All errors (new ones prefixed by >>): >>> >>> Thanks, we nee

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: > On 4/7/21 10:03 AM, Andy Shevchenko wrote: > > On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: ... > >> All errors (new ones prefixed by >>): > > > > Thanks, we need to include bits.h. > > (It passed my simple build

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Jens Axboe
On 4/7/21 10:03 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: >> Hi Andy, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on block/for-next] >> [also build test ERROR on v5.12-rc6 next-20210407] >> [If your patch is a

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Yet something to improve: > > [auto build test ERROR on block/for-next] > [also build test ERROR on v5.12-rc6 next-20210407] > [If your patch is applied to the wrong git tree, kindly drop us a not

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread kernel test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v5.12-rc6 next-20210407] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https:/

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Jens Axboe
On 4/7/21 7:47 AM, Andy Shevchenko wrote: > There is no need to have kernel.h included, I do not see any > direct users of it in ata.h. Drop unneeded inclusion of kernel.h. Applied, thanks. -- Jens Axboe

[PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Andy Shevchenko
There is no need to have kernel.h included, I do not see any direct users of it in ata.h. Drop unneeded inclusion of kernel.h. Signed-off-by: Andy Shevchenko --- include/linux/ata.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/ata.h b/include/linux/ata.h index 6e67aded28f8..2