Re: [PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-07-21 Thread Guido Günther
Hi, On Tue, May 14, 2024 at 06:05:20PM +0200, Guido Günther wrote: > Hi, > On Mon, May 13, 2024 at 03:13:53PM -0700, Dmitry Torokhov wrote: > > Hi Guido, > > > > On Thu, May 09, 2024 at 02:00:28PM +0200, Guido Günther wrote: > > > This helps user space to figure out which keys should be used to un

Re: [PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-05-14 Thread Guido Günther
Hi, On Mon, May 13, 2024 at 03:13:53PM -0700, Dmitry Torokhov wrote: > Hi Guido, > > On Thu, May 09, 2024 at 02:00:28PM +0200, Guido Günther wrote: > > This helps user space to figure out which keys should be used to unidle a > > device. E.g on phones the volume rocker should usually not unblank t

Re: [PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-05-13 Thread Dmitry Torokhov
Hi Guido, On Thu, May 09, 2024 at 02:00:28PM +0200, Guido Günther wrote: > This helps user space to figure out which keys should be used to unidle a > device. E.g on phones the volume rocker should usually not unblank the > screen. How exactly this is supposed to be used? We have "disabled" keys

Re: [PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-05-13 Thread Geert Uytterhoeven
Hi Guido, On Thu, May 9, 2024 at 2:00 PM Guido Günther wrote: > This helps user space to figure out which keys should be used to unidle a > device. E.g on phones the volume rocker should usually not unblank the > screen. > > Signed-off-by: Guido Günther Thanks for your patch! This is indeed a u

[PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-05-09 Thread Guido Günther
This helps user space to figure out which keys should be used to unidle a device. E.g on phones the volume rocker should usually not unblank the screen. Signed-off-by: Guido Günther --- drivers/input/keyboard/gpio_keys.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions