Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-10-01 Thread Moritz Fischer
Hi Russ, On Wed, Sep 30, 2020 at 06:07:00PM -0700, Russ Weight wrote: > > Hi Moritz, > > On 9/30/20 5:31 PM, Moritz Fischer wrote: > > I think providing the devm_ managed APIs is nicer, and makes it easier > > for the consumer of the API to do the right thing. > > I see that the fpga_mgr code h

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-30 Thread Russ Weight
Hi Moritz, On 9/30/20 5:31 PM, Moritz Fischer wrote: > I think providing the devm_ managed APIs is nicer, and makes it easier > for the consumer of the API to do the right thing. I see that the fpga_mgr code has support for two versions of the create() and register() functions, one uses the dev

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-30 Thread Moritz Fischer
Hi Russ, On Wed, Sep 30, 2020 at 01:54:50PM -0700, Russ Weight wrote: > > > On 9/16/20 1:16 PM, Moritz Fischer wrote: > > Hi Russ, > > > > On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > >> Create the Intel Security Manager class driver. The security > >> manager provides interfac

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-30 Thread Russ Weight
On 9/16/20 1:16 PM, Moritz Fischer wrote: > Hi Russ, > > On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: >> Create the Intel Security Manager class driver. The security >> manager provides interfaces to manage secure updates for the >> FPGA and BMC images that are stored in FLASH. T

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-16 Thread Moritz Fischer
Hi Russ, On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry has

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-10 Thread Russ Weight
On 9/10/20 2:51 PM, Tom Rix wrote: > On 9/10/20 1:22 PM, Russ Weight wrote: >> >> >> On 9/5/20 12:09 PM, Tom Rix wrote: >> >> >> >>> >>> On 9/4/20 4:52 PM, Russ Weight wrote: >>> Create the Intel Security Manager class driver. The security manager p

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-10 Thread Tom Rix
On 9/10/20 1:22 PM, Russ Weight wrote: > > > On 9/5/20 12:09 PM, Tom Rix wrote: > > > >> >> On 9/4/20 4:52 PM, Russ Weight wrote: >> >>> >>> Create the Intel Security Manager class driver. The security >>> manager provides interfaces to manage secure updates for th

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-05 Thread Tom Rix
On 9/4/20 4:52 PM, Russ Weight wrote: > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry hashes and to cancel code > signin

RE: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-05 Thread Wu, Hao
> On 9/4/20 5:23 PM, Moritz Fischer wrote: > > Hi Russ, > > > > On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > >> Create the Intel Security Manager class driver. The security > >> manager provides interfaces to manage secure updates for the > >> FPGA and BMC images that are stored i

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-04 Thread Russ Weight
On 9/4/20 5:23 PM, Moritz Fischer wrote: Hi Russ, On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: Create the Intel Security Manager class driver. The security manager provides interfaces to manage secure updates for the FPGA and BMC images that are stored in FLASH. The driver can

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-04 Thread Moritz Fischer
Hi Russ, On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry has

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-04 Thread Randy Dunlap
On 9/4/20 4:52 PM, Russ Weight wrote: > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 88f64fbf55e3..97c0a6cc2ba7 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -235,4 +235,13 @@ config FPGA_MGR_ZYNQMP_FPGA > to configure the programmable logic(PL) t

[PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-04 Thread Russ Weight
Create the Intel Security Manager class driver. The security manager provides interfaces to manage secure updates for the FPGA and BMC images that are stored in FLASH. The driver can also be used to update root entry hashes and to cancel code signing keys. This patch creates the class driver and p