Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-22 Thread Cindy Lu
On Thu, 12 Sept 2024 at 10:11, Jason Wang wrote: > > > > On Thu, Sep 12, 2024 at 12:17 AM Mike Christie > wrote: >> >> On 9/10/24 10:45 PM, Jason Wang wrote: >> >>> It depends on how we define "secure". There's plenty of users of >> >>> kthread and if I was not wrong, mike may still need to fix

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-11 Thread Jason Wang
On Thu, Sep 12, 2024 at 3:02 AM Michael S. Tsirkin wrote: > > On Wed, Sep 11, 2024 at 11:20:30AM -0500, Mike Christie wrote: > > If people are ok with something similar as in this patchset where > > we have both vhost_tasks and kthreads, then I can send something. > > > It would be better, as you

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 11:20:30AM -0500, Mike Christie wrote: > If people are ok with something similar as in this patchset where > we have both vhost_tasks and kthreads, then I can send something. It would be better, as you say, to modify the vhost_task code so it can emulate the kthread behavi

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-11 Thread Mike Christie
On 9/10/24 2:41 AM, Michael S. Tsirkin wrote: > On Mon, Sep 09, 2024 at 10:00:38AM +0800, Cindy Lu wrote: >> In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), >> vhost removed the support for the kthread API. However, there are >> still situations where there is a request to use

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-11 Thread Mike Christie
On 9/10/24 10:45 PM, Jason Wang wrote: >>> It depends on how we define "secure". There's plenty of users of >>> kthread and if I was not wrong, mike may still need to fix some bugs. >>> >> >> which bugs? > > https://lore.kernel.org/all/06369c2c-c363-4def-9ce0-f018a9e10...@oracle.com/T/ The SIGKIL

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 11:45:33AM +0800, Jason Wang wrote: > On Tue, Sep 10, 2024 at 4:43 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 10, 2024 at 04:37:52PM +0800, Jason Wang wrote: > > > On Tue, Sep 10, 2024 at 3:42 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Sep 09, 2024 a

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-10 Thread Jason Wang
On Tue, Sep 10, 2024 at 4:43 PM Michael S. Tsirkin wrote: > > On Tue, Sep 10, 2024 at 04:37:52PM +0800, Jason Wang wrote: > > On Tue, Sep 10, 2024 at 3:42 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 09, 2024 at 10:00:38AM +0800, Cindy Lu wrote: > > > > In commit 6e890c5d5021 ("vhost: use

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-10 Thread Michael S. Tsirkin
On Tue, Sep 10, 2024 at 04:37:52PM +0800, Jason Wang wrote: > On Tue, Sep 10, 2024 at 3:42 PM Michael S. Tsirkin wrote: > > > > On Mon, Sep 09, 2024 at 10:00:38AM +0800, Cindy Lu wrote: > > > In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), > > > vhost removed the support for

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-10 Thread Jason Wang
On Tue, Sep 10, 2024 at 3:42 PM Michael S. Tsirkin wrote: > > On Mon, Sep 09, 2024 at 10:00:38AM +0800, Cindy Lu wrote: > > In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), > > vhost removed the support for the kthread API. However, there are > > still situations where there i

Re: [RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-10 Thread Michael S. Tsirkin
On Mon, Sep 09, 2024 at 10:00:38AM +0800, Cindy Lu wrote: > In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), > vhost removed the support for the kthread API. However, there are > still situations where there is a request to use kthread. > In this PATCH, the support of kthread i

[RESEND PATCH v1 0/7]vhost: Add support of kthread API

2024-09-08 Thread Cindy Lu
In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), vhost removed the support for the kthread API. However, there are still situations where there is a request to use kthread. In this PATCH, the support of kthread is added back. Additionally, a module_param is added to enforce whi

[PATCH v1 0/7] vhost: Add support of kthread API

2024-09-08 Thread Cindy Lu
Tested the user application with QEMU. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), vhost removed the support for the kthread API. However, there are still situations where there is a