Re: [PATCH v1 0/5] Introduce a new helper marco DEFINE_STORE_ATTRIBUTE at seq_file.c

Hi On 2020/10/22 20:28, Al Viro wrote: On Thu, Oct 22, 2020 at 04:39:52PM +0800, Luo Jiaxing wrote: We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but we found many of drivers also want a helper marco for read-write file too. DEFINE_SHOW_ATTRIBUT

Re: [PATCH v1 0/5] Introduce a new helper marco DEFINE_STORE_ATTRIBUTE at seq_file.c

On Thu, Oct 22, 2020 at 04:39:52PM +0800, Luo Jiaxing wrote: > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute > for read-only file, but we found many of drivers also want a helper marco for > read-write file too. DEFINE_SHOW_ATTRIBUTE is a bloody bad idea; let's not rep

[PATCH v1 0/5] Introduce a new helper marco DEFINE_STORE_ATTRIBUTE at seq_file.c

We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but we found many of drivers also want a helper marco for read-write file too. So we try to add this macro to help decrease code duplication. Luo Jiaxing (5): seq_file: Introduce DEFINE_STORE_ATTRIBUT