Re: [PATCH v1] x86: punit_atom: punit device state debug driver

2015-05-06 Thread Ingo Molnar
* Srinivas Pandruvada wrote: > > > diff --git a/arch/x86/kernel/punit_atom_debug.c > > > b/arch/x86/kernel/punit_atom_debug.c > > > > Please put this somewhere suitable in arch/x86/platform/. > > I moved this to arch/x86/platform/intel-mid, but punit is much more > part of common core atom so

Re: [PATCH v1] x86: punit_atom: punit device state debug driver

2015-05-05 Thread Srinivas Pandruvada
Hi Ingo and Thomas, One question inside on location. On Sat, 2015-05-02 at 08:00 +0200, Ingo Molnar wrote: > * Srinivas Pandruvada wrote: > > > The patch adds a debug driver, which dumps the power states > > of all the North complex (NC) devices. This debug interface is > > useful to figure out t

Re: [PATCH v1] x86: punit_atom: punit device state debug driver

2015-05-04 Thread Srinivas Pandruvada
On Sat, 2015-05-02 at 08:00 +0200, Ingo Molnar wrote: Thanks for the review > * Srinivas Pandruvada wrote: > > > The patch adds a debug driver, which dumps the power states > > of all the North complex (NC) devices. This debug interface is > > useful to figure out the NC IPs which blocks the S0

Re: [PATCH v1] x86: punit_atom: punit device state debug driver

2015-05-02 Thread Borislav Petkov
On Sat, May 02, 2015 at 08:00:51AM +0200, Ingo Molnar wrote: > Btw., you can have multiple MODULE_AUTHOR() lines, so you can credit > yourself as well. Take a look at drivers/net/wireless/at76c50x-usb.c's > MODULE_AUTHOR() for grins. Oh boy, I propose a vararg macro called MODULE_GANG(...) -- R

Re: [PATCH v1] x86: punit_atom: punit device state debug driver

2015-05-01 Thread Ingo Molnar
* Srinivas Pandruvada wrote: > The patch adds a debug driver, which dumps the power states > of all the North complex (NC) devices. This debug interface is > useful to figure out the NC IPs which blocks the S0ix > transitions on the platform. This is extremely useful during > enabling PM on cust

[PATCH v1] x86: punit_atom: punit device state debug driver

2015-05-01 Thread Srinivas Pandruvada
The patch adds a debug driver, which dumps the power states of all the North complex (NC) devices. This debug interface is useful to figure out the NC IPs which blocks the S0ix transitions on the platform. This is extremely useful during enabling PM on customer platforms and derivatives. This subm

[PATCH v1] x86: punit_atom: punit device state debug driver

2015-05-01 Thread Srinivas Pandruvada
v1 Based on review comments - Changed to tristate instead of bool - Moved config to kconfig.debug - Added debug in module name - Returning -ENXIO on debugfs file create error v0: Base version Srinivas Pandruvada (1): x86: punit_atom: punit device state debug driver arch/x86/Kconfig.debug