Re: R: [PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-22 Thread Guenter Roeck
On Mon, Feb 22, 2021 at 11:28:18AM +, Flavio Suligoi wrote: [ ... ] > > Having said that, I'd prefer to have a module parameter in the watchdog > > core. We already have a number of similar module parameters in various > > drivers, all named differently, and I'd rather not have more. > > Ok, I

RE: R: [PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-22 Thread Flavio Suligoi
Hi Guenter > >>>const struct wdat_instruction *instr, u32 *value) { @@ -437,6 > >>> +443,8 @@ static int wdat_wdt_probe(struct platform_device > >> *pdev) > >>> } > >>> > >>> wdat_wdt_boot_status(wdat); > >>> + if (start_enabled) > >>> + wdat_wdt_start(&wdat->wdd); > >> > >> No ob

Re: R: [PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-19 Thread Guenter Roeck
On 2/19/21 6:01 AM, Flavio Suligoi wrote: > Hi Mika, > >>> const struct wdat_instruction *instr, u32 *value) >>> { >>> @@ -437,6 +443,8 @@ static int wdat_wdt_probe(struct platform_device >> *pdev) >>> } >>> >>> wdat_wdt_boot_status(wdat); >>> + if (start_enabled) >>> + w

R: [PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-19 Thread Flavio Suligoi
Hi Mika, > > const struct wdat_instruction *instr, u32 *value) > > { > > @@ -437,6 +443,8 @@ static int wdat_wdt_probe(struct platform_device > *pdev) > > } > > > > wdat_wdt_boot_status(wdat); > > + if (start_enabled) > > + wdat_wdt_start(&wdat->wdd); > > No objections t

Re: [PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-19 Thread Mika Westerberg
Hi, On Thu, Feb 18, 2021 at 05:32:00PM +0100, Flavio Suligoi wrote: > Add the parameter "start_enable" to start the watchdog > directly on module insertion. > > In an embedded system, for some applications, the watchdog > must be activated as soon as possible. > > In some embedded x86 boards the

[PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-18 Thread Flavio Suligoi
Add the parameter "start_enable" to start the watchdog directly on module insertion. In an embedded system, for some applications, the watchdog must be activated as soon as possible. In some embedded x86 boards the watchdog can be activated directly by the BIOS (with an appropriate setting of the