Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 03:27:25PM +0530, Gaurav Kohli wrote: > > > On 1/24/2021 8:51 AM, Steven Rostedt wrote: > > On Sat, 23 Jan 2021 22:03:27 +0530 > > Gaurav Kohli wrote: > > > > > > > Sure I will do, I have never posted on backport branches. Let me check > > > and post it. > > > > > > >

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-24 Thread Gaurav Kohli
On 1/24/2021 8:51 AM, Steven Rostedt wrote: On Sat, 23 Jan 2021 22:03:27 +0530 Gaurav Kohli wrote: Sure I will do, I have never posted on backport branches. Let me check and post it. Basically you take your original patch that was in mainline (as the subject and commit message), and mak

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-23 Thread Steven Rostedt
On Sat, 23 Jan 2021 22:03:27 +0530 Gaurav Kohli wrote: > Sure I will do, I have never posted on backport branches. Let me check > and post it. > Basically you take your original patch that was in mainline (as the subject and commit message), and make it work as if you were doing the same exac

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-23 Thread Gaurav Kohli
On 1/23/2021 4:19 PM, Denis Efremov wrote: On 1/22/21 5:37 PM, Steven Rostedt wrote: On Fri, 22 Jan 2021 16:55:29 +0530 Gaurav Kohli wrote: That could possibly work. Yes, this will work, As i have tested similar patch for internal testing for kernel branches like 5.4/4.19. Can you or

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-23 Thread Denis Efremov
On 1/22/21 5:37 PM, Steven Rostedt wrote: > On Fri, 22 Jan 2021 16:55:29 +0530 > Gaurav Kohli wrote: > That could possibly work. >> >> Yes, this will work, As i have tested similar patch for internal testing >> for kernel branches like 5.4/4.19. > > Can you or Denis send a proper patc

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-22 Thread Steven Rostedt
On Fri, 22 Jan 2021 16:55:29 +0530 Gaurav Kohli wrote: > >> That could possibly work. > > Yes, this will work, As i have tested similar patch for internal testing > for kernel branches like 5.4/4.19. Can you or Denis send a proper patch for Greg to backport? I'll review it, test it and give

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-22 Thread Greg KH
On Thu, Jan 21, 2021 at 03:37:32PM -0500, Steven Rostedt wrote: > On Thu, 21 Jan 2021 23:15:22 +0300 > Denis Efremov wrote: > > > On 1/21/21 10:09 PM, Steven Rostedt wrote: > > > On Thu, 21 Jan 2021 17:30:40 +0300 > > > Denis Efremov wrote: > > > > > >> Hi, > > >> > > >> This patch (CVE-2020-

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-22 Thread Gaurav Kohli
On 1/22/2021 4:29 PM, Greg KH wrote: On Thu, Jan 21, 2021 at 03:37:32PM -0500, Steven Rostedt wrote: On Thu, 21 Jan 2021 23:15:22 +0300 Denis Efremov wrote: On 1/21/21 10:09 PM, Steven Rostedt wrote: On Thu, 21 Jan 2021 17:30:40 +0300 Denis Efremov wrote: Hi, This patch (CVE-2020-2

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-21 Thread Steven Rostedt
On Thu, 21 Jan 2021 23:15:22 +0300 Denis Efremov wrote: > On 1/21/21 10:09 PM, Steven Rostedt wrote: > > On Thu, 21 Jan 2021 17:30:40 +0300 > > Denis Efremov wrote: > > > >> Hi, > >> > >> This patch (CVE-2020-27825) was tagged with > >> Fixes: b23d7a5f4a07a ("ring-buffer: speed up buffer rese

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-21 Thread Denis Efremov
On 1/21/21 10:09 PM, Steven Rostedt wrote: > On Thu, 21 Jan 2021 17:30:40 +0300 > Denis Efremov wrote: > >> Hi, >> >> This patch (CVE-2020-27825) was tagged with >> Fixes: b23d7a5f4a07a ("ring-buffer: speed up buffer resets by avoiding >> synchronize_rcu for each CPU") >> >> I'm not an expert

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-21 Thread Steven Rostedt
On Thu, 21 Jan 2021 17:30:40 +0300 Denis Efremov wrote: > Hi, > > This patch (CVE-2020-27825) was tagged with > Fixes: b23d7a5f4a07a ("ring-buffer: speed up buffer resets by avoiding > synchronize_rcu for each CPU") > > I'm not an expert here but it seems like b23d7a5f4a07a only refactored > r

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-21 Thread Denis Efremov
Hi, This patch (CVE-2020-27825) was tagged with Fixes: b23d7a5f4a07a ("ring-buffer: speed up buffer resets by avoiding synchronize_rcu for each CPU") I'm not an expert here but it seems like b23d7a5f4a07a only refactored ring_buffer_reset_cpu() by introducing reset_disabled_cpu_buffer() without

[PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-10-06 Thread Gaurav Kohli
Below race can come, if trace_open and resize of cpu buffer is running parallely on different cpus CPUXCPUY ring_buffer_resize atomic_read(&buffer->resize_disabled) tracing_open tracing_reset_onl

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-10-05 Thread Gaurav Kohli
On 10/5/2020 10:02 PM, Steven Rostedt wrote: On Mon, 5 Oct 2020 21:59:02 +0530 Gaurav Kohli wrote: Hi Steven, I am using normal git send-email(never saw problem with this), Not sure what is wrong. In my older mail i have kept you in to and rest in cc. Let me try to resent it. The Cc is

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-10-05 Thread Steven Rostedt
On Mon, 5 Oct 2020 21:59:02 +0530 Gaurav Kohli wrote: > Hi Steven, > > I am using normal git send-email(never saw problem with this), Not sure > what is wrong. In my older mail i have kept you in to and rest in cc. > > Let me try to resent it. The Cc is working (I got it in my LKML box), but

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-10-05 Thread Gaurav Kohli
On 10/5/2020 7:57 PM, Steven Rostedt wrote: On Mon, 5 Oct 2020 10:25:15 -0400 Steven Rostedt wrote: On Mon, 5 Oct 2020 10:09:34 +0530 Gaurav Kohli wrote: Hi Steven, please let us know, if below looks good to you or need modifications. Strange, I don't have your original email in my in

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-10-05 Thread Steven Rostedt
On Mon, 5 Oct 2020 10:25:15 -0400 Steven Rostedt wrote: > On Mon, 5 Oct 2020 10:09:34 +0530 > Gaurav Kohli wrote: > > > Hi Steven, > > > > please let us know, if below looks good to you or need modifications. > > Strange, I don't have your original email in my inbox. I do have it in my > LK

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-10-05 Thread Steven Rostedt
On Mon, 5 Oct 2020 10:09:34 +0530 Gaurav Kohli wrote: > Hi Steven, > > please let us know, if below looks good to you or need modifications. Strange, I don't have your original email in my inbox. I do have it in my LKML folder, but that's way too big for me to read. I checked my server logs. I

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-10-04 Thread Gaurav Kohli
Hi Steven, please let us know, if below looks good to you or need modifications. Thanks Gaurav On 9/24/2020 7:25 PM, Gaurav Kohli wrote: Below race can come, if trace_open and resize of cpu buffer is running parallely on different cpus CPUXCPUY

[PATCH v1] trace: Fix race in trace_open and buffer resize call

2020-09-24 Thread Gaurav Kohli
Below race can come, if trace_open and resize of cpu buffer is running parallely on different cpus CPUXCPUY ring_buffer_resize atomic_read(&buffer->resize_disabled) tracing_open tracing_reset_onl