Re: [PATCH v1] tcpm: Honour pSnkStdby requirement during negotiation

2020-08-04 Thread Badhri Jagan Sridharan
Hi Guenter, Your concern is very valid ! I was myself pondering at the significance and meaning of current_limit, supply_voltage. I will pen down what I understood from reading the code. If it makes sense, I will add the documentation to the change as well. In TOT code i.e. without the patch in d

Re: [PATCH v1] tcpm: Honour pSnkStdby requirement during negotiation

2020-08-04 Thread Guenter Roeck
On 8/3/20 11:51 PM, Badhri Jagan Sridharan wrote: >>From PD Spec: > The Sink Shall transition to Sink Standby before a positive or > negative voltage transition of VBUS. During Sink Standby > the Sink Shall reduce its power draw to pSnkStdby. This allows > the Source to manage the voltage transitio

Re: [PATCH v1] tcpm: Honour pSnkStdby requirement during negotiation

2020-08-04 Thread kernel test robot
Hi Badhri, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on next-20200803] [cannot apply to v5.8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--

[PATCH v1] tcpm: Honour pSnkStdby requirement during negotiation

2020-08-03 Thread Badhri Jagan Sridharan
>From PD Spec: The Sink Shall transition to Sink Standby before a positive or negative voltage transition of VBUS. During Sink Standby the Sink Shall reduce its power draw to pSnkStdby. This allows the Source to manage the voltage transition as well as supply sufficient operating current to the Sin