R: R: R: R: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-16 Thread Flavio Suligoi
Hi Peter, > >>> > >>> dmesg| grep ttyS > >> > >> But as they work the same, why does it matter? > > > > Yes you are right, by the user point of view, they are the same. > > > >> > >> Userspace should not care here. Isn't there some other id you can > >> read/query for a hardware database tool to

Re: R: R: R: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-15 Thread Ji-Ze Hong (Peter Hong)
Hi, Flavio Suligoi 於 2020/12/15 下午 11:06 寫道: we produce some x86 boards with multistandard RS232/422/485 ports and, to have this feature, in some of these boards, we use a Fintek uart or superIO. So this additional info "extra_name" can be useful for a quick check if the serial ports are multist

R: R: R: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-15 Thread Flavio Suligoi
Hi Greg, > > > Fintek F81216AD > > > > 00:02: ttyS3 at I/O 0x2e8 (irq = 11, base_baud = 115200) is a 16550A > - > > > Fintek F81216AD > > > > > > > > where the "extra_name", if not empty, is printed > > > > at the end of the line. > > > > For practical space reasons, the "extra_name" length > > >

Re: R: R: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-15 Thread Greg Kroah-Hartman
On Tue, Dec 15, 2020 at 02:06:09PM +, Flavio Suligoi wrote: > Hi Greg, > > > > > > > + chip_name = "F81216H"; > > > > > + break; > > > > > case CHIP_ID_F81216: > > > > > + chip_name = "F81216"; > > > > > break; > > > > > default: >

R: R: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-15 Thread Flavio Suligoi
Hi Greg, > > > > + chip_name = "F81216H"; > > > > + break; > > > > case CHIP_ID_F81216: > > > > + chip_name = "F81216"; > > > > break; > > > > default: > > > > return -ENODEV; > > > > } > > > > > > >

Re: R: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-15 Thread Greg Kroah-Hartman
On Tue, Dec 15, 2020 at 01:35:31PM +, Flavio Suligoi wrote: > Hi Greg, > > > > > > > switch (chip) { > > > case CHIP_ID_F81865: > > > + chip_name = "F81865"; > > > + break; > > > case CHIP_ID_F81866: > > > + chip_name = "F81866"; > > > + break; > > > cas

R: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-15 Thread Flavio Suligoi
Hi Greg, > > > > switch (chip) { > > case CHIP_ID_F81865: > > + chip_name = "F81865"; > > + break; > > case CHIP_ID_F81866: > > + chip_name = "F81866"; > > + break; > > case CHIP_ID_F81966: > > + chip_name = "F81966"; > > +

Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-14 Thread Jiri Slaby
On 15. 12. 20, 1:29, Ji-Ze Hong (Peter Hong) wrote: Hi, Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道:   pdata->pid = chip; + +    pr_info("%s%s%s Fintek %s\n", +    uart->port.dev ? dev_name(uart->port.dev) : "", +    uart->port.dev ? ": " : "", +    uart->port.name, +    chi

Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-14 Thread Ji-Ze Hong (Peter Hong)
Hi, Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道: pdata->pid = chip; + + pr_info("%s%s%s Fintek %s\n", + uart->port.dev ? dev_name(uart->port.dev) : "", + uart->port.dev ? ": " : "", + uart->port.name, + chip_name); Drivers,

Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-14 Thread Greg Kroah-Hartman
On Mon, Dec 14, 2020 at 02:14:45PM +0100, Flavio Suligoi wrote: > At the moment, if a Fintek UART is detected, there is no > printed information about this. > The ttyS port is declared as a simple 16550A port, but, > especially when we want to use the RS485 mode, it's > very important understand if

[PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-14 Thread Flavio Suligoi
At the moment, if a Fintek UART is detected, there is no printed information about this. The ttyS port is declared as a simple 16550A port, but, especially when we want to use the RS485 mode, it's very important understand if the Fintek UART is correctly detected as expected. Signed-off-by: Flavio