Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-07-08 Thread Douglas Gilbert
On 2019-07-08 2:01 a.m., Hannes Reinecke wrote: On 7/5/19 7:53 PM, Douglas Gilbert wrote: On 2019-07-05 3:22 a.m., Hannes Reinecke wrote: [ .. ] As mentioned, rescan-scsi-bus.sh is keeping references to /proc/scsi as a fall back only, as it's meant to work kernel independent. Per default it'll

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-07-07 Thread Hannes Reinecke
On 7/5/19 7:53 PM, Douglas Gilbert wrote: > On 2019-07-05 3:22 a.m., Hannes Reinecke wrote: [ .. ] >> As mentioned, rescan-scsi-bus.sh is keeping references to /proc/scsi as >> a fall back only, as it's meant to work kernel independent. Per default >> it'll be using /sys, and will happily work with

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-07-05 Thread Douglas Gilbert
...@interlog.com; Marc Gonzalez ; James Bottomley ; Martin Petersen Cc: SCSI ; LKML ; Christoph Hellwig Subject: Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default On 6/17/19 5:35 PM, Douglas Gilbert wrote: For sg3_utils: $ find . -name '*.c' -exec grep "/proc/scsi&

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-07-05 Thread Hannes Reinecke
; To: dgilb...@interlog.com; Marc Gonzalez ; James >> Bottomley >> ; Martin Petersen >> Cc: SCSI ; LKML ; >> Christoph Hellwig >> >> Subject: Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default >> >> On 6/17/19 5:35 PM, Douglas Gilb

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-07-05 Thread Hannes Reinecke
On 6/18/19 5:28 AM, Bart Van Assche wrote: > On 6/17/19 5:35 PM, Douglas Gilbert wrote: >> For sg3_utils: >> >> $ find . -name '*.c' -exec grep "/proc/scsi" {} \; -print >> static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio"; >> ./src/sg_read.c >> static const char * proc_allow_dio = "/p

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-21 Thread Finn Thain
On Fri, 21 Jun 2019, Marc Gonzalez wrote: > On 21/06/2019 01:43, Finn Thain wrote: > > > On Thu, 20 Jun 2019, Marc Gonzalez wrote: > > > >> How likely is it that distro kernels would *not* enable CHR_DEV_SG? > >> (Distros tend to enable everything, and then some.) > > > > How likely is it that

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-21 Thread Marc Gonzalez
On 21/06/2019 01:43, Finn Thain wrote: > On Thu, 20 Jun 2019, Marc Gonzalez wrote: > >> How likely is it that distro kernels would *not* enable CHR_DEV_SG? >> (Distros tend to enable everything, and then some.) > > How likely is it that embedded developers would *not* disable CHR_DEV_SG? > They

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-20 Thread Finn Thain
On Thu, 20 Jun 2019, Marc Gonzalez wrote: > > How likely is it that distro kernels would *not* enable CHR_DEV_SG? > (Distros tend to enable everything, and then some.) > How likely is it that embedded developers would *not* disable CHR_DEV_SG? They tend to disable everything, and then enable

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-20 Thread Martin K. Petersen
Marc, > (I work on smaller systems where we do use /proc occasionally, but we > don't enable CHR_DEV_SG or SCSI_PROC_FS.) Many sg apps depend on SCSI_PROC_FS. That doesn't imply that only sg apps depend on it. As an example, with SCSI_PROC_FS enabled we don't need your SanDisk Cruzer Blade pat

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-20 Thread Marc Gonzalez
On 19/06/2019 16:34, Douglas Gilbert wrote: > On 2019-06-19 5:42 a.m., Marc Gonzalez wrote: > >> I assume sg3_utils requires CHR_DEV_SG. Is it the case? >> >> If so, we would just need to enable SCSI_PROC_FS when CHR_DEV_SG is enabled. >> >> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfi

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-19 Thread Douglas Gilbert
On 2019-06-19 5:42 a.m., Marc Gonzalez wrote: On 18/06/2019 17:31, Douglas Gilbert wrote: On 2019-06-18 3:29 a.m., Marc Gonzalez wrote: Please note that I am _in no way_ suggesting that we remove any code. I just think it might be time to stop forcing CONFIG_SCSI_PROC_FS into every config, a

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-19 Thread Marc Gonzalez
On 18/06/2019 17:31, Douglas Gilbert wrote: > On 2019-06-18 3:29 a.m., Marc Gonzalez wrote: > >> Please note that I am _in no way_ suggesting that we remove any code. >> >> I just think it might be time to stop forcing CONFIG_SCSI_PROC_FS into >> every config, and instead require one to explicitl

RE: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-18 Thread Elliott, Robert (Servers)
ersen > Cc: SCSI ; LKML ; > Christoph Hellwig > > Subject: Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default > > On 6/17/19 5:35 PM, Douglas Gilbert wrote: > > For sg3_utils: > > > > $ find . -name '*.c' -exec grep "/proc/scsi

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-18 Thread Douglas Gilbert
On 2019-06-18 3:29 a.m., Marc Gonzalez wrote: On 18/06/2019 03:08, Finn Thain wrote: On Mon, 17 Jun 2019, Douglas Gilbert wrote: On 2019-06-17 5:11 p.m., Bart Van Assche wrote: On 6/12/19 6:59 AM, Marc Gonzalez wrote: According to the option's help message, SCSI_PROC_FS has been supersede

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-18 Thread Marc Gonzalez
On 18/06/2019 03:08, Finn Thain wrote: > On Mon, 17 Jun 2019, Douglas Gilbert wrote: > >> On 2019-06-17 5:11 p.m., Bart Van Assche wrote: >> >>> On 6/12/19 6:59 AM, Marc Gonzalez wrote: >>> According to the option's help message, SCSI_PROC_FS has been superseded for ~15 years. Don't sel

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-17 Thread Bart Van Assche
On 6/17/19 5:35 PM, Douglas Gilbert wrote: For sg3_utils: $ find . -name '*.c' -exec grep "/proc/scsi" {} \; -print static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio"; ./src/sg_read.c static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio"; ./src/sgp_dd.c static const char * p

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-17 Thread Finn Thain
On Mon, 17 Jun 2019, Douglas Gilbert wrote: > On 2019-06-17 5:11 p.m., Bart Van Assche wrote: > > On 6/12/19 6:59 AM, Marc Gonzalez wrote: > > > According to the option's help message, SCSI_PROC_FS has been > > > superseded for ~15 years. Don't select it by default anymore. > > > > > > Signed-off

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-17 Thread Douglas Gilbert
On 2019-06-17 5:11 p.m., Bart Van Assche wrote: On 6/12/19 6:59 AM, Marc Gonzalez wrote: According to the option's help message, SCSI_PROC_FS has been superseded for ~15 years. Don't select it by default anymore. Signed-off-by: Marc Gonzalez ---   drivers/scsi/Kconfig | 3 ---   1 file changed,

Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-17 Thread Bart Van Assche
On 6/12/19 6:59 AM, Marc Gonzalez wrote: According to the option's help message, SCSI_PROC_FS has been superseded for ~15 years. Don't select it by default anymore. Signed-off-by: Marc Gonzalez --- drivers/scsi/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/Kconfi

[PATCH v1] scsi: Don't select SCSI_PROC_FS by default

2019-06-12 Thread Marc Gonzalez
According to the option's help message, SCSI_PROC_FS has been superseded for ~15 years. Don't select it by default anymore. Signed-off-by: Marc Gonzalez --- drivers/scsi/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 73bce9b6d037..