Re: [PATCH v1] regulator: core: Log forbidden DRMS operation

2019-02-21 Thread Mark Brown
On Thu, Feb 21, 2019 at 10:42:01AM +0100, Marc Gonzalez wrote: > On 19/02/2019 17:39, Mark Brown wrote: > > On Tue, Feb 19, 2019 at 05:02:46PM +0100, Marc Gonzalez wrote: > > No, it's perfectly normal for machine constraints to stop drivers from > > doing things so we shouldn't warn on this - it w

Re: [PATCH v1] regulator: core: Log forbidden DRMS operation

2019-02-21 Thread Marc Gonzalez
[ SMTP server blocked by spamcop -- trying a different one ] On 19/02/2019 17:39, Mark Brown wrote: > On Tue, Feb 19, 2019 at 05:02:46PM +0100, Marc Gonzalez wrote: > >> When REGULATOR_CHANGE_DRMS is not set, drms_uA_update is a no-op. >> It used to print a debug message, which was dropped in co

Re: [PATCH v1] regulator: core: Log forbidden DRMS operation

2019-02-21 Thread Marc Gonzalez
On 19/02/2019 17:39, Mark Brown wrote: > On Tue, Feb 19, 2019 at 05:02:46PM +0100, Marc Gonzalez wrote: > >> When REGULATOR_CHANGE_DRMS is not set, drms_uA_update is a no-op. >> It used to print a debug message, which was dropped in commit >> 8a34e979f684 ("regulator: refactor valid_ops_mask chec

Re: [PATCH v1] regulator: core: Log forbidden DRMS operation

2019-02-20 Thread Mark Brown
On Tue, Feb 19, 2019 at 05:02:46PM +0100, Marc Gonzalez wrote: > When REGULATOR_CHANGE_DRMS is not set, drms_uA_update is a no-op. > It used to print a debug message, which was dropped in commit > 8a34e979f684 ("regulator: refactor valid_ops_mask checking code") > Let's bring the debug message bac

[PATCH v1] regulator: core: Log forbidden DRMS operation

2019-02-19 Thread Marc Gonzalez
When REGULATOR_CHANGE_DRMS is not set, drms_uA_update is a no-op. It used to print a debug message, which was dropped in commit 8a34e979f684 ("regulator: refactor valid_ops_mask checking code") Let's bring the debug message back as KERN_INFO, because it is very useful to diagnose missing regulator