Hi Thomas,
>
> > > >
---
> > > > static void macronix_nand_onfi_init(struct nand_chip *chip)
> > > > {
> > > > struct nand_parameters *p = &chip->parameters;
> > > > struct nand_onfi_vendor_macronix *mxic = (
Hello,
On Tue, 14 May 2019 09:53:16 +0800
masonccy...@mxic.com.tw wrote:
> > > ---
> > > static void macronix_nand_onfi_init(struct nand_chip *chip)
> > > {
> > > struct nand_parameters *p = &chip->parameters;
> > >
Hi Miquel,
> > > > > > +
> > > > > > + if (mxic->reliability_func & MACRONIX_READ_RETRY_BIT) {
> > > > > > + chip->read_retries = MACRONIX_READ_RETRY_MODE + 1;
> > > > >
> > > > > Why +1 here, I am missing something?
> > > >
> > > >
> > > > Without + 1, read retry mode is up t
Hi Mason,
masonccy...@mxic.com.tw wrote on Mon, 13 May 2019 15:47:53 +0800:
> Hi Miquel,
>
>
> > >
> > > >
> > > > > + if (ret)
> > > > > + pr_err("set feature failed to read retry moded:%d\n",
> mode);
> > > >
> > > >"Failed to set read retry mode: %d\
Hello,
On Mon, 13 May 2019 15:37:39 +0800
masonccy...@mxic.com.tw wrote:
> ---
> static void macronix_nand_onfi_init(struct nand_chip *chip)
> {
> struct nand_parameters *p = &chip->parameters;
> struct nand_onf
Hello,
Thomas Petazzoni wrote on Fri, 10 May
2019 15:37:04 +0200:
> Hello,
>
> Some purely cosmetic suggestions below.
>
> On Fri, 10 May 2019 15:41:02 +0800
> Mason Yang wrote:
>
> > + if (ret)
> > + pr_err("set feature failed to read retry moded:%d\n", mode);
>
> I don't k
Hi Mason,
Thomas Petazzoni wrote on Fri, 10 May
2019 15:37:04 +0200:
> Hello,
>
> Some purely cosmetic suggestions below.
>
> On Fri, 10 May 2019 15:41:02 +0800
> Mason Yang wrote:
>
> > + if (ret)
> > + pr_err("set feature failed to read retry moded:%d\n", mode);
>
> I don'
Hello,
Some purely cosmetic suggestions below.
On Fri, 10 May 2019 15:41:02 +0800
Mason Yang wrote:
> + if (ret)
> + pr_err("set feature failed to read retry moded:%d\n", mode);
I don't know what is the policy in the MTD/NAND subsystem, but
shouldn't you be using dev_err() in
Hi Mason,
masonccy...@mxic.com.tw wrote on Fri, 10 May 2019 16:51:20 +0800:
> Hi Miquel,
>
>
> > > Add a driver for Macronix NAND read retry.
> >
> > "Add support for Macronix NAND read retry."? This is not a "new driver".
> >
> > >
> > > Macronix NAND supports specfical read for data re
Hi Mason,
Mason Yang wrote on Fri, 10 May 2019 15:41:02
+0800:
> Add a driver for Macronix NAND read retry.
"Add support for Macronix NAND read retry."? This is not a "new driver".
>
> Macronix NAND supports specfical read for data recovery and enabled
Macronix NANDs support specific read o
Add a driver for Macronix NAND read retry.
Macronix NAND supports specfical read for data recovery and enabled
it by Set Feature.
Driver check byte 167 of Vendor Blocks in ONFI parameter page table
to see if this high reliability function is support or not.
Signed-off-by: Mason Yang
---
drivers
11 matches
Mail list logo
