Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it

2019-01-29 Thread David Hildenbrand
On 30.01.19 00:16, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: d6d86c0a7f8d mm/balloon_compaction: redesign ballooned pages > management. > > The bot has tested the following trees: v4.20.5, v4

Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it

2019-01-29 Thread David Hildenbrand
On 29.01.19 08:18, Michal Hocko wrote: > On Mon 28-01-19 22:09:14, David Hildenbrand wrote: >> On 28.01.19 21:19, Michal Hocko wrote: > [...] >>> David, could you reformulate the changelog accordingly please? My ack >>> still holds. >> >> You mean reformulating + resending for stable kernels only?

Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it

2019-01-28 Thread Michal Hocko
On Mon 28-01-19 22:09:14, David Hildenbrand wrote: > On 28.01.19 21:19, Michal Hocko wrote: [...] > > David, could you reformulate the changelog accordingly please? My ack > > still holds. > > You mean reformulating + resending for stable kernels only? I would merge your patch even if it doesn't

Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it

2019-01-28 Thread David Hildenbrand
On 28.01.19 21:19, Michal Hocko wrote: > On Mon 28-01-19 21:02:52, David Hildenbrand wrote: >> On 28.01.19 17:04, David Hildenbrand wrote: >>> While debugging some crashes related to virtio-balloon deflation that >>> happened under the old balloon migration code, I stumbled over a race >>> that sti

Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it

2019-01-28 Thread Michal Hocko
On Mon 28-01-19 21:02:52, David Hildenbrand wrote: > On 28.01.19 17:04, David Hildenbrand wrote: > > While debugging some crashes related to virtio-balloon deflation that > > happened under the old balloon migration code, I stumbled over a race > > that still exists today. > > > > What we experien

Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it

2019-01-28 Thread David Hildenbrand
On 28.01.19 17:04, David Hildenbrand wrote: > While debugging some crashes related to virtio-balloon deflation that > happened under the old balloon migration code, I stumbled over a race > that still exists today. > > What we experienced: > > drivers/virtio/virtio_balloon.c:release_pages_balloon

[PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it

2019-01-28 Thread David Hildenbrand
While debugging some crashes related to virtio-balloon deflation that happened under the old balloon migration code, I stumbled over a race that still exists today. What we experienced: drivers/virtio/virtio_balloon.c:release_pages_balloon(): - WARNING: CPU: 13 PID: 6586 at lib/list_debug.c:59 __