Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-23 Thread Naoya Horiguchi
On Sun, Apr 22, 2018 at 08:03:49PM -0700, Matthew Wilcox wrote: > On Fri, Apr 06, 2018 at 03:07:11AM +, Naoya Horiguchi wrote: > > Subject: [PATCH] mm: enable thp migration for shmem thp > > This patch is buggy, but not in a significant way: > > > @@ -524,13 +524,26 @@ int migrate_page_move_m

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-22 Thread Matthew Wilcox
On Fri, Apr 06, 2018 at 03:07:11AM +, Naoya Horiguchi wrote: > Subject: [PATCH] mm: enable thp migration for shmem thp This patch is buggy, but not in a significant way: > @@ -524,13 +524,26 @@ int migrate_page_move_mapping(struct address_space > *mapping, > } > > radix_tree_re

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-11 Thread Michal Hocko
On Wed 11-04-18 12:27:39, Andrew Morton wrote: > On Wed, 11 Apr 2018 11:26:11 +0200 Michal Hocko wrote: > > > On Fri 06-04-18 03:07:11, Naoya Horiguchi wrote: > > > >From e31ec037701d1cc76b26226e4b66d8c783d40889 Mon Sep 17 00:00:00 2001 > > > From: Naoya Horiguchi > > > Date: Fri, 6 Apr 2018 10:

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-11 Thread Andrew Morton
On Wed, 11 Apr 2018 11:26:11 +0200 Michal Hocko wrote: > On Fri 06-04-18 03:07:11, Naoya Horiguchi wrote: > > >From e31ec037701d1cc76b26226e4b66d8c783d40889 Mon Sep 17 00:00:00 2001 > > From: Naoya Horiguchi > > Date: Fri, 6 Apr 2018 10:58:35 +0900 > > Subject: [PATCH] mm: enable thp migration f

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-11 Thread Michal Hocko
On Fri 06-04-18 03:07:11, Naoya Horiguchi wrote: > >From e31ec037701d1cc76b26226e4b66d8c783d40889 Mon Sep 17 00:00:00 2001 > From: Naoya Horiguchi > Date: Fri, 6 Apr 2018 10:58:35 +0900 > Subject: [PATCH] mm: enable thp migration for shmem thp > > My testing for the latest kernel supporting thp m

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-10 Thread Kirill A. Shutemov
On Fri, Apr 06, 2018 at 03:07:11AM +, Naoya Horiguchi wrote: > Hi everyone, > > On Thu, Apr 05, 2018 at 06:03:17PM +0200, Michal Hocko wrote: > > On Thu 05-04-18 18:55:51, Kirill A. Shutemov wrote: > > > On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote: > > > > On Thu 05-04-18 16:4

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-09 Thread Naoya Horiguchi
On Fri, Apr 06, 2018 at 09:08:15AM +0200, Michal Hocko wrote: > On Fri 06-04-18 05:14:53, Naoya Horiguchi wrote: > > On Fri, Apr 06, 2018 at 03:07:11AM +, Horiguchi Naoya(堀口 直也) wrote: > > ... > > > - > > > From e31ec037701d1cc76b26226e4b66d8c783d40889 Mon Sep 17 00:00:00 2001 > > > From: N

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-06 Thread Michal Hocko
On Fri 06-04-18 05:14:53, Naoya Horiguchi wrote: > On Fri, Apr 06, 2018 at 03:07:11AM +, Horiguchi Naoya(堀口 直也) wrote: > ... > > - > > From e31ec037701d1cc76b26226e4b66d8c783d40889 Mon Sep 17 00:00:00 2001 > > From: Naoya Horiguchi > > Date: Fri, 6 Apr 2018 10:58:35 +0900 > > Subject: [PAT

Re: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-05 Thread Naoya Horiguchi
On Fri, Apr 06, 2018 at 03:07:11AM +, Horiguchi Naoya(堀口 直也) wrote: ... > - > From e31ec037701d1cc76b26226e4b66d8c783d40889 Mon Sep 17 00:00:00 2001 > From: Naoya Horiguchi > Date: Fri, 6 Apr 2018 10:58:35 +0900 > Subject: [PATCH] mm: enable thp migration for shmem thp > > My testing for

[PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)

2018-04-05 Thread Naoya Horiguchi
Hi everyone, On Thu, Apr 05, 2018 at 06:03:17PM +0200, Michal Hocko wrote: > On Thu 05-04-18 18:55:51, Kirill A. Shutemov wrote: > > On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote: > > > On Thu 05-04-18 16:40:45, Kirill A. Shutemov wrote: > > > > On Thu, Apr 05, 2018 at 02:48:30PM +0

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Zi Yan
On 5 Apr 2018, at 15:04, Michal Hocko wrote: > On Thu 05-04-18 13:58:43, Zi Yan wrote: >> On 5 Apr 2018, at 12:03, Michal Hocko wrote: >> >>> On Thu 05-04-18 18:55:51, Kirill A. Shutemov wrote: On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote: > On Thu 05-04-18 16:40:45, Kiril

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Michal Hocko
On Thu 05-04-18 13:58:43, Zi Yan wrote: > On 5 Apr 2018, at 12:03, Michal Hocko wrote: > > > On Thu 05-04-18 18:55:51, Kirill A. Shutemov wrote: > >> On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote: > >>> On Thu 05-04-18 16:40:45, Kirill A. Shutemov wrote: > On Thu, Apr 05, 2018

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Zi Yan
On 5 Apr 2018, at 12:03, Michal Hocko wrote: > On Thu 05-04-18 18:55:51, Kirill A. Shutemov wrote: >> On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote: >>> On Thu 05-04-18 16:40:45, Kirill A. Shutemov wrote: On Thu, Apr 05, 2018 at 02:48:30PM +0200, Michal Hocko wrote: >>> [...] >

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Michal Hocko
On Thu 05-04-18 18:55:51, Kirill A. Shutemov wrote: > On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote: > > On Thu 05-04-18 16:40:45, Kirill A. Shutemov wrote: > > > On Thu, Apr 05, 2018 at 02:48:30PM +0200, Michal Hocko wrote: > > [...] > > > > RIght, I confused the two. What is the pr

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Kirill A. Shutemov
On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote: > On Thu 05-04-18 16:40:45, Kirill A. Shutemov wrote: > > On Thu, Apr 05, 2018 at 02:48:30PM +0200, Michal Hocko wrote: > [...] > > > RIght, I confused the two. What is the proper layer to fix that then? > > > rmap_walk_file? > > > > Ma

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Michal Hocko
On Thu 05-04-18 16:40:45, Kirill A. Shutemov wrote: > On Thu, Apr 05, 2018 at 02:48:30PM +0200, Michal Hocko wrote: [...] > > RIght, I confused the two. What is the proper layer to fix that then? > > rmap_walk_file? > > Maybe something like this? Totally untested. This looks way too complex. Why

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Kirill A. Shutemov
On Thu, Apr 05, 2018 at 02:48:30PM +0200, Michal Hocko wrote: > On Thu 05-04-18 15:28:38, Kirill A. Shutemov wrote: > > On Thu, Apr 05, 2018 at 10:59:27AM +0200, Michal Hocko wrote: > > > On Tue 03-04-18 13:54:11, Kirill A. Shutemov wrote: > > > > On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Ho

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Michal Hocko
On Thu 05-04-18 15:28:38, Kirill A. Shutemov wrote: > On Thu, Apr 05, 2018 at 10:59:27AM +0200, Michal Hocko wrote: > > On Tue 03-04-18 13:54:11, Kirill A. Shutemov wrote: > > > On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Hocko wrote: > > > > On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: >

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Kirill A. Shutemov
On Thu, Apr 05, 2018 at 10:59:27AM +0200, Michal Hocko wrote: > On Tue 03-04-18 13:54:11, Kirill A. Shutemov wrote: > > On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Hocko wrote: > > > On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: > > > > On Tue, Apr 03, 2018 at 09:59:28AM +0200, Michal Hocko

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-05 Thread Michal Hocko
On Tue 03-04-18 13:54:11, Kirill A. Shutemov wrote: > On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Hocko wrote: > > On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: > > > On Tue, Apr 03, 2018 at 09:59:28AM +0200, Michal Hocko wrote: > > > > On Tue 03-04-18 13:46:28, Naoya Horiguchi wrote: > > >

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-03 Thread Michal Hocko
On Tue 03-04-18 14:16:18, Kirill A. Shutemov wrote: > On Tue, Apr 03, 2018 at 12:58:15PM +0200, Michal Hocko wrote: > > On Tue 03-04-18 13:54:11, Kirill A. Shutemov wrote: > > > On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Hocko wrote: > > > > On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: >

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-03 Thread Kirill A. Shutemov
On Tue, Apr 03, 2018 at 12:58:15PM +0200, Michal Hocko wrote: > On Tue 03-04-18 13:54:11, Kirill A. Shutemov wrote: > > On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Hocko wrote: > > > On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: > > > > On Tue, Apr 03, 2018 at 09:59:28AM +0200, Michal Hocko

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-03 Thread Michal Hocko
On Tue 03-04-18 13:54:11, Kirill A. Shutemov wrote: > On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Hocko wrote: > > On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: > > > On Tue, Apr 03, 2018 at 09:59:28AM +0200, Michal Hocko wrote: > > > > On Tue 03-04-18 13:46:28, Naoya Horiguchi wrote: > > >

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-03 Thread Kirill A. Shutemov
On Tue, Apr 03, 2018 at 10:34:51AM +0200, Michal Hocko wrote: > On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: > > On Tue, Apr 03, 2018 at 09:59:28AM +0200, Michal Hocko wrote: > > > On Tue 03-04-18 13:46:28, Naoya Horiguchi wrote: > > > > My testing for the latest kernel supporting thp migration

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-03 Thread Michal Hocko
On Tue 03-04-18 08:24:06, Naoya Horiguchi wrote: > On Tue, Apr 03, 2018 at 09:59:28AM +0200, Michal Hocko wrote: > > On Tue 03-04-18 13:46:28, Naoya Horiguchi wrote: > > > My testing for the latest kernel supporting thp migration found out an > > > infinite loop in offlining the memory block that i

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-03 Thread Naoya Horiguchi
On Tue, Apr 03, 2018 at 09:59:28AM +0200, Michal Hocko wrote: > On Tue 03-04-18 13:46:28, Naoya Horiguchi wrote: > > My testing for the latest kernel supporting thp migration found out an > > infinite loop in offlining the memory block that is filled with shmem > > thps. We can get out of the loop

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-03 Thread Michal Hocko
On Tue 03-04-18 13:46:28, Naoya Horiguchi wrote: > My testing for the latest kernel supporting thp migration found out an > infinite loop in offlining the memory block that is filled with shmem > thps. We can get out of the loop with a signal, but kernel should > return with failure in this case.

[PATCH v1] mm: consider non-anonymous thp as unmovable page

2018-04-02 Thread Naoya Horiguchi
My testing for the latest kernel supporting thp migration found out an infinite loop in offlining the memory block that is filled with shmem thps. We can get out of the loop with a signal, but kernel should return with failure in this case. What happens in the loop is that scan_movable_pages() re