Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-12-02 Thread Wolfram Sang
On Sat, Nov 07, 2020 at 01:51:51PM +0530, Vaibhav Gupta wrote: > After the commit c5eb1190074c ("PCI / PM: Allow runtime PM without callback > functions") we no more need empty stubs for runtime-pm to work. > > The driver has no device specific task(s) for .suspend() . The stub was > placed just f

Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-11-11 Thread Jarkko Nikula
On 11/11/20 12:54 PM, Vaibhav Gupta wrote: On Tue, Nov 10, 2020 at 02:33:43PM +0200, Jarkko Nikula wrote: +#define gpu_i2c_suspend NULL Perhaps we can put NULL directly into UNIVERSAL_DEV_PM_OPS() for the suspend callback? Yes. I have noticed that the approach for this is random. Many drivers

Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-11-11 Thread Vaibhav Gupta
On Tue, Nov 10, 2020 at 02:33:43PM +0200, Jarkko Nikula wrote: > On 11/7/20 11:04 AM, Vaibhav Gupta wrote: > > On Sat, Nov 07, 2020 at 01:51:51PM +0530, Vaibhav Gupta wrote: > > > After the commit c5eb1190074c ("PCI / PM: Allow runtime PM without > > > callback > > > functions") we no more need em

Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-11-10 Thread Jarkko Nikula
On 11/7/20 11:04 AM, Vaibhav Gupta wrote: On Sat, Nov 07, 2020 at 01:51:51PM +0530, Vaibhav Gupta wrote: After the commit c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions") we no more need empty stubs for runtime-pm to work. The driver has no device specific task(s) for .sus

Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-11-07 Thread Vaibhav Gupta
On Sat, Nov 07, 2020 at 01:51:51PM +0530, Vaibhav Gupta wrote: > After the commit c5eb1190074c ("PCI / PM: Allow runtime PM without callback > functions") we no more need empty stubs for runtime-pm to work. > > The driver has no device specific task(s) for .suspend() . The stub was > placed just f

[PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-11-07 Thread Vaibhav Gupta
After the commit c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions") we no more need empty stubs for runtime-pm to work. The driver has no device specific task(s) for .suspend() . The stub was placed just for runtime-pm, which can be dropped now. Reported-by: Bjorn Helgaas Sig