Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference

2017-08-14 Thread Wolfram Sang
On Fri, Jul 28, 2017 at 06:00:12PM -0700, Brendan Higgins wrote: > Before I skipped null checks when the master is in the STOP state; this > fixes that. > > Signed-off-by: Brendan Higgins Applied to for-current, thanks! signature.asc Description: PGP signature

Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference

2017-08-13 Thread Joel Stanley
On Sat, Aug 12, 2017 at 9:02 PM, Wolfram Sang wrote: > On Fri, Jul 28, 2017 at 06:00:12PM -0700, Brendan Higgins wrote: >> Before I skipped null checks when the master is in the STOP state; this >> fixes that. >> >> Signed-off-by: Brendan Higgins > > Is there a suitable "Fixes:" tag for this? >

Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference

2017-08-12 Thread Wolfram Sang
On Fri, Jul 28, 2017 at 06:00:12PM -0700, Brendan Higgins wrote: > Before I skipped null checks when the master is in the STOP state; this > fixes that. > > Signed-off-by: Brendan Higgins Is there a suitable "Fixes:" tag for this? signature.asc Description: PGP signature

Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference

2017-07-31 Thread Brendan Higgins
On Mon, Jul 31, 2017 at 2:27 AM, Joel Stanley wrote: > On Sat, Jul 29, 2017 at 10:30 AM, Brendan Higgins > wrote: >> Before I skipped null checks when the master is in the STOP state; this >> fixes that. >> >> Signed-off-by: Brendan Higgins > > Acked-by: Joel Stanley > > Out of interest, was th

Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference

2017-07-31 Thread Joel Stanley
On Sat, Jul 29, 2017 at 10:30 AM, Brendan Higgins wrote: > Before I skipped null checks when the master is in the STOP state; this > fixes that. > > Signed-off-by: Brendan Higgins Acked-by: Joel Stanley Out of interest, was this found by code review, or did you hit this in testing? Cheers, J

[PATCH v1] i2c: aspeed: fixed potential null pointer dereference

2017-07-28 Thread Brendan Higgins
Before I skipped null checks when the master is in the STOP state; this fixes that. Signed-off-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index