Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

2016-10-26 Thread Mika Westerberg
On Wed, Oct 26, 2016 at 04:20:57PM +0700, Tin Huynh wrote: >We need to set stop bit if three conditions are true : The latest >bytes , the latest msg_write_ids and after receiving the buffer length. >If we use i2c_dw_xfer_need_stop , arguments of function are complex. OK, so you would

Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

2016-10-26 Thread Mika Westerberg
On Wed, Oct 26, 2016 at 02:26:05PM +0700, Tin Huynh wrote: >But can you explain more about 'but even that starts to require small >helper function'? So you could add a small function i2c_dw_xfer_need_stop() that returns true if you need to set the stop bit.

Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

2016-10-25 Thread Andy Shevchenko
On Tue, 2016-10-25 at 14:50 +0300, Mika Westerberg wrote: > On Tue, Oct 25, 2016 at 11:35:13AM +0700, tnhu...@apm.com wrote: > > --  > > CONFIDENTIALITY NOTICE: This e-mail message, including any > > attachments, is  > > for the sole use of the intended recipient(s) and contains > > information th

Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

2016-10-25 Thread Mika Westerberg
On Tue, Oct 25, 2016 at 11:35:13AM +0700, tnhu...@apm.com wrote: > From: Tin Huynh > > Free and Open IPMI use SMBUS BLOCK Read/Write to support SSIF protocol. > However, I2C Designwave Core Driver doesn't handle the case at the moment. > The below patch supports this feature. > > Signed-off-by:

Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

2016-10-25 Thread Jarkko Nikula
Hi On 10/25/2016 07:35 AM, tnhu...@apm.com wrote: --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -220,6 +220,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) I2C_FUNC_SMBUS_BYTE | I2C_FUNC_SMBU

[PATCH v1] I2C Designware Core Supports SMBUS BLOCK

2016-10-24 Thread tnhuynh
From: Tin Huynh Free and Open IPMI use SMBUS BLOCK Read/Write to support SSIF protocol. However, I2C Designwave Core Driver doesn't handle the case at the moment. The below patch supports this feature. Signed-off-by: Tin Huynh --- drivers/i2c/busses/i2c-designware-core.c| 42