Re: [PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-10-06 Thread Charles Keepax
On Fri, Oct 06, 2017 at 08:03:23AM +, Nicholas Mc Guire wrote: > On Sun, Sep 24, 2017 at 12:18:12AM +, Levin, Alexander (Sasha Levin) > wrote: > > On Fri, Sep 22, 2017 at 09:46:28AM +0100, Charles Keepax wrote: > > >On Wed, Sep 20, 2017 at 04:45:02AM +, Levin, Alexander (Sasha Levin)

Re: [PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-10-06 Thread Nicholas Mc Guire
On Sun, Sep 24, 2017 at 12:18:12AM +, Levin, Alexander (Sasha Levin) wrote: > On Fri, Sep 22, 2017 at 09:46:28AM +0100, Charles Keepax wrote: > >On Wed, Sep 20, 2017 at 04:45:02AM +, Levin, Alexander (Sasha Levin) > >wrote: > >> From: Nicholas Mc Guire > >> > >> [ Upstream commit ed784c53

Re: [PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-09-23 Thread Levin, Alexander (Sasha Levin)
On Fri, Sep 22, 2017 at 09:46:28AM +0100, Charles Keepax wrote: >On Wed, Sep 20, 2017 at 04:45:02AM +, Levin, Alexander (Sasha Levin) wrote: >> From: Nicholas Mc Guire >> >> [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] >> >> The delay here is not in atomic context and does not

Re: [PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-09-22 Thread Charles Keepax
On Wed, Sep 20, 2017 at 04:45:02AM +, Levin, Alexander (Sasha Levin) wrote: > From: Nicholas Mc Guire > > [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] > > The delay here is not in atomic context and does not seem critical with > respect to precision, but usleep_range(min,max)

[PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Nicholas Mc Guire [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] The delay here is not in atomic context and does not seem critical with respect to precision, but usleep_range(min,max) with min==max results in giving the timer subsystem no room to optimize uncritical delays.