Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread Tom Yan
Strange. I merely changed the two "char" to "u8". I wonder how the tab became spaces. Anyway, sorry about that, resending soon. On 22 July 2016 at 17:59, Sergei Shtylyov wrote: > Hello. > > > On 7/22/2016 2:29 AM, tom.t...@gmail.com wrote: > >> From: Tom Yan >> >> ata_mselect_*() would initializ

Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread Sergei Shtylyov
Hello. On 7/22/2016 2:29 AM, tom.t...@gmail.com wrote: From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff fro

[PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-21 Thread tom . ty89
From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff from def_control_mpage[] would become -1. This prevented ata_m

[PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-21 Thread tom . ty89
From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff from def_control_mpage[] would become -1. This prevented ata_m