Re: [PATCH resend 2/6] cdrom: factor out common open_for_* code

On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > - ret=cdo->tray_move(cdi,0); > + ret = cdo->tray_move(cdi, 0); Please separate whitespace-only changes from functional changes such that this patch series becomes easier to review.

[PATCH resend 2/6] cdrom: factor out common open_for_* code

The open_for_audio and open_for_data copies are bitrotten in different ways already and will need to update the autoclose logic in both. Signed-off-by: Michal Suchanek --- drivers/cdrom/cdrom.c | 100 ++ 1 file changed, 36 insertions(+), 64 deletio