Re: [PATCH resend] virtio_console: Free buffers from out-queue upon close

2012-11-08 Thread Sjur Brændeland
>> > Note: This patch is compile tested only. I have done the removal >> > of buffers from out-queue in handle_control_message() >> > when host has acked the close request. This seems less >> > racy than doing it in the release function. >> >> This confuses me... why are we doing this in case >> VI

Re: [PATCH resend] virtio_console: Free buffers from out-queue upon close

2012-11-08 Thread Amit Shah
On (Thu) 08 Nov 2012 [10:28:53], Rusty Russell wrote: > sjur.brandel...@stericsson.com writes: > > > From: Sjur Brændeland > > > > Free pending output buffers from the virtio out-queue when > > host has acknowledged port_close. Also removed WARN_ON() > > in remove_port_data(). > > > > Signed-off-

Re: [PATCH resend] virtio_console: Free buffers from out-queue upon close

2012-11-07 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Sjur Brændeland > > Free pending output buffers from the virtio out-queue when > host has acknowledged port_close. Also removed WARN_ON() > in remove_port_data(). > > Signed-off-by: Sjur Brændeland > --- > > Resending, this time including a proper "

[PATCH resend] virtio_console: Free buffers from out-queue upon close

2012-11-07 Thread sjur . brandeland
From: Sjur Brændeland Free pending output buffers from the virtio out-queue when host has acknowledged port_close. Also removed WARN_ON() in remove_port_data(). Signed-off-by: Sjur Brændeland --- Resending, this time including a proper "Subject"... -- Hi Amit, Note: This patch is compile tes