Re: [PATCH next] of/fdt: Fix defined but not used compiler warning

2019-06-14 Thread Kefeng Wang
On 2019/6/14 21:53, Rob Herring wrote: > On Wed, Jun 12, 2019 at 12:29 PM Frank Rowand wrote: >> >> On 6/12/19 10:00 AM, Rob Herring wrote: >>> On Wed, Jun 12, 2019 at 10:45 AM Frank Rowand >>> wrote: Hi Kefeng, If Rob agrees, I'd like to see one more change in this patch.

Re: [PATCH next] of/fdt: Fix defined but not used compiler warning

2019-06-14 Thread Rob Herring
On Wed, Jun 12, 2019 at 12:29 PM Frank Rowand wrote: > > On 6/12/19 10:00 AM, Rob Herring wrote: > > On Wed, Jun 12, 2019 at 10:45 AM Frank Rowand > > wrote: > >> > >> Hi Kefeng, > >> > >> If Rob agrees, I'd like to see one more change in this patch. > >> > >> Since the only caller of of_fdt_mat

Re: [PATCH next] of/fdt: Fix defined but not used compiler warning

2019-06-12 Thread Frank Rowand
On 6/12/19 10:00 AM, Rob Herring wrote: > On Wed, Jun 12, 2019 at 10:45 AM Frank Rowand wrote: >> >> Hi Kefeng, >> >> If Rob agrees, I'd like to see one more change in this patch. >> >> Since the only caller of of_fdt_match() is of_flat_dt_match(), >> can you move the body of of_fdt_match() into

Re: [PATCH next] of/fdt: Fix defined but not used compiler warning

2019-06-12 Thread Rob Herring
On Wed, Jun 12, 2019 at 10:45 AM Frank Rowand wrote: > > Hi Kefeng, > > If Rob agrees, I'd like to see one more change in this patch. > > Since the only caller of of_fdt_match() is of_flat_dt_match(), > can you move the body of of_fdt_match() into of_flat_dt_match() > and eliminate of_fdt_match()

Re: [PATCH next] of/fdt: Fix defined but not used compiler warning

2019-06-12 Thread Frank Rowand
Hi Kefeng, If Rob agrees, I'd like to see one more change in this patch. Since the only caller of of_fdt_match() is of_flat_dt_match(), can you move the body of of_fdt_match() into of_flat_dt_match() and eliminate of_fdt_match()? (Noting that of_flat_dt_match() consists only of the call to of_f

Re: [PATCH next] of/fdt: Fix defined but not used compiler warning

2019-06-12 Thread Stephen Boyd
Quoting Kefeng Wang (2019-06-11 18:00:11) > When CONFIG_OF_EARLY_FLATTREE is disabled, there is a compiler warning, > > drivers/of/fdt.c:129:19: warning: ‘of_fdt_match’ defined but not used > [-Wunused-function] > static int __init of_fdt_match(const void *blob, unsigned long node, > > Move of_

[PATCH next] of/fdt: Fix defined but not used compiler warning

2019-06-11 Thread Kefeng Wang
When CONFIG_OF_EARLY_FLATTREE is disabled, there is a compiler warning, drivers/of/fdt.c:129:19: warning: ‘of_fdt_match’ defined but not used [-Wunused-function] static int __init of_fdt_match(const void *blob, unsigned long node, Move of_fdt_match() and of_fdt_is_compatible() under CONFIG_OF_E