RE: [PATCH net v2] vsock: Fix a lockdep warning in __vsock_release()

2019-09-30 Thread Dexuan Cui
> From: Stefano Garzarella > Sent: Monday, September 30, 2019 6:51 AM > ... > Feel free to add: > > Tested-by: Stefano Garzarella Thanks, Stefano! I'll post a v3 with your suggestion "lock_sock_nested(sk, level);". It does look better than v2 to me. :-) Thanks, -- Dexuan

Re: [PATCH net v2] vsock: Fix a lockdep warning in __vsock_release()

2019-09-30 Thread Stefano Garzarella
On Fri, Sep 27, 2019 at 05:37:20AM +, Dexuan Cui wrote: > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of Stefano Garzarella > > Sent: Thursday, September 26, 2019 12:48 AM > > > > Hi Dexuan, > > > > On Thu, Sep 26, 2019 at 01:11:27AM +, Dexuan Cui wrote: > > > ... > > > NOTE

Re: [PATCH net v2] vsock: Fix a lockdep warning in __vsock_release()

2019-09-27 Thread Stefano Garzarella
On Fri, Sep 27, 2019 at 05:37:20AM +, Dexuan Cui wrote: > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of Stefano Garzarella > > Sent: Thursday, September 26, 2019 12:48 AM > > > > Hi Dexuan, > > > > On Thu, Sep 26, 2019 at 01:11:27AM +, Dexuan Cui wrote: > > > ... > > > NOTE

RE: [PATCH net v2] vsock: Fix a lockdep warning in __vsock_release()

2019-09-26 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Stefano Garzarella > Sent: Thursday, September 26, 2019 12:48 AM > > Hi Dexuan, > > On Thu, Sep 26, 2019 at 01:11:27AM +, Dexuan Cui wrote: > > ... > > NOTE: I only tested the code on Hyper-V. I can not test the code for > > virtio so

Re: [PATCH net v2] vsock: Fix a lockdep warning in __vsock_release()

2019-09-26 Thread Stefano Garzarella
Hi Dexuan, On Thu, Sep 26, 2019 at 01:11:27AM +, Dexuan Cui wrote: > Lockdep is unhappy if two locks from the same class are held. > > Fix the below warning for hyperv and virtio sockets (vmci socket code > doesn't have the issue) by using lock_sock_nested() when __vsock_release() > is called

[PATCH net v2] vsock: Fix a lockdep warning in __vsock_release()

2019-09-25 Thread Dexuan Cui
Lockdep is unhappy if two locks from the same class are held. Fix the below warning for hyperv and virtio sockets (vmci socket code doesn't have the issue) by using lock_sock_nested() when __vsock_release() is called recursively: WARNING: possible recu