Re: [PATCH net V3] virtio-net: validate features during probe

2014-11-19 Thread Jason Wang
On 11/20/2014 03:02 PM, Michael S. Tsirkin wrote: > On Thu, Nov 20, 2014 at 02:10:35PM +0800, Jason Wang wrote: >> We currently trigger BUG when VIRTIO_NET_F_CTRL_VQ >> is not set but one of features depending on it is. >> That's not a friendly way to report errors to >> hypervisors. >> Let's check

Re: [PATCH net V3] virtio-net: validate features during probe

2014-11-19 Thread Michael S. Tsirkin
On Thu, Nov 20, 2014 at 02:10:35PM +0800, Jason Wang wrote: > We currently trigger BUG when VIRTIO_NET_F_CTRL_VQ > is not set but one of features depending on it is. > That's not a friendly way to report errors to > hypervisors. > Let's check, and fail probe instead. > > Cc: Rusty Russell > Cc: C

[PATCH net V3] virtio-net: validate features during probe

2014-11-19 Thread Jason Wang
We currently trigger BUG when VIRTIO_NET_F_CTRL_VQ is not set but one of features depending on it is. That's not a friendly way to report errors to hypervisors. Let's check, and fail probe instead. Cc: Rusty Russell Cc: Cornelia Huck Cc: Wanlong Gao Signed-off-by: Michael S. Tsirkin Signed-off