Re: [PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive

2017-10-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:06 +1100 > ncsi_channel_monitor() misses stopping the channel monitor in several > places that it should, causing a WARN_ON_ONCE() to trigger when the > monitor is re-started later, eg: > > [ 459.04] WARNING: CPU: 0 PID: 1093 at net/nc

[PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive

2017-10-18 Thread Samuel Mendoza-Jonas
ncsi_channel_monitor() misses stopping the channel monitor in several places that it should, causing a WARN_ON_ONCE() to trigger when the monitor is re-started later, eg: [ 459.04] WARNING: CPU: 0 PID: 1093 at net/ncsi/ncsi-manage.c:269 ncsi_start_channel_monitor+0x7c/0x90 [ 459.04] CPU