Re: [PATCH net-next v7 3/3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-15 Thread Tao Ren
On 8/15/19 4:36 PM, Florian Fainelli wrote: > On 8/11/19 4:40 PM, Tao Ren wrote: >> The BCM54616S PHY cannot work properly in RGMII->1000Base-X mode, mainly >> because genphy functions are designed for copper links, and 1000Base-X >> (clause 37) auto negotiation needs to be handled differently. >>

Re: [PATCH net-next v7 3/3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-15 Thread Florian Fainelli
On 8/11/19 4:40 PM, Tao Ren wrote: > The BCM54616S PHY cannot work properly in RGMII->1000Base-X mode, mainly > because genphy functions are designed for copper links, and 1000Base-X > (clause 37) auto negotiation needs to be handled differently. > > This patch enables 1000Base-X support for BCM54

Re: [PATCH net-next v7 3/3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-15 Thread Tao Ren
On 8/15/19 4:15 PM, Vladimir Oltean wrote: > Hi Tao, > > On Fri, 16 Aug 2019 at 02:13, Tao Ren wrote: >> >> Hi Andrew / Florian / Heiner / Vladimir, >> >> Any further suggestions on the patch series? >> >> >> Thanks, >> >> Tao >> >> On 8/11/19 4:40 PM, Tao Ren wrote: >>> The BCM54616S PHY cannot

Re: [PATCH net-next v7 3/3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-15 Thread Vladimir Oltean
Hi Tao, On Fri, 16 Aug 2019 at 02:13, Tao Ren wrote: > > Hi Andrew / Florian / Heiner / Vladimir, > > Any further suggestions on the patch series? > > > Thanks, > > Tao > > On 8/11/19 4:40 PM, Tao Ren wrote: > > The BCM54616S PHY cannot work properly in RGMII->1000Base-X mode, mainly > > because

Re: [PATCH net-next v7 3/3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-15 Thread Tao Ren
Hi Andrew / Florian / Heiner / Vladimir, Any further suggestions on the patch series? Thanks, Tao On 8/11/19 4:40 PM, Tao Ren wrote: > The BCM54616S PHY cannot work properly in RGMII->1000Base-X mode, mainly > because genphy functions are designed for copper links, and 1000Base-X > (clause 37)

[PATCH net-next v7 3/3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-11 Thread Tao Ren
The BCM54616S PHY cannot work properly in RGMII->1000Base-X mode, mainly because genphy functions are designed for copper links, and 1000Base-X (clause 37) auto negotiation needs to be handled differently. This patch enables 1000Base-X support for BCM54616S by customizing 3 driver callbacks, and i