Re: [PATCH net-next v7 05/12] selftests: ncdevmem: Remove default arguments

2024-11-04 Thread Joe Damato
On Mon, Nov 04, 2024 at 10:14:23AM -0800, Stanislav Fomichev wrote: > To make it clear what's required and what's not. Also, some of the > values don't seem like a good defaults; for example eth1. > > Move the invocation comment to the top, add missing -s to the client > and cleanup the client inv

[PATCH net-next v7 05/12] selftests: ncdevmem: Remove default arguments

2024-11-04 Thread Stanislav Fomichev
To make it clear what's required and what's not. Also, some of the values don't seem like a good defaults; for example eth1. Move the invocation comment to the top, add missing -s to the client and cleanup the client invocation a bit to make more readable. Reviewed-by: Mina Almasry Signed-off-by