Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-10 Thread Michal Kubecek
On Tue, Jul 09, 2019 at 03:42:12PM +0200, Jiri Pirko wrote: > Mon, Jul 08, 2019 at 10:22:19PM CEST, mkube...@suse.cz wrote: > >On Mon, Jul 08, 2019 at 09:26:29PM +0200, Jiri Pirko wrote: > >> Mon, Jul 08, 2019 at 07:27:29PM CEST, mkube...@suse.cz wrote: > >> > > >> >There are two reasons for this d

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-09 Thread Jiri Pirko
Mon, Jul 08, 2019 at 10:22:19PM CEST, mkube...@suse.cz wrote: >On Mon, Jul 08, 2019 at 09:26:29PM +0200, Jiri Pirko wrote: >> Mon, Jul 08, 2019 at 07:27:29PM CEST, mkube...@suse.cz wrote: >> > >> >There are two reasons for this design. First is to reduce the number of >> >requests needed to get the

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-08 Thread Michal Kubecek
On Mon, Jul 08, 2019 at 09:26:29PM +0200, Jiri Pirko wrote: > Mon, Jul 08, 2019 at 07:27:29PM CEST, mkube...@suse.cz wrote: > > > >There are two reasons for this design. First is to reduce the number of > >requests needed to get the information. This is not so much a problem of > >ethtool itself; t

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-08 Thread Jiri Pirko
Mon, Jul 08, 2019 at 09:26:29PM CEST, j...@resnulli.us wrote: >Mon, Jul 08, 2019 at 07:27:29PM CEST, mkube...@suse.cz wrote: >>On Wed, Jul 03, 2019 at 10:41:51AM +0200, Jiri Pirko wrote: >>> Tue, Jul 02, 2019 at 04:52:41PM CEST, mkube...@suse.cz wrote: >>> >On Tue, Jul 02, 2019 at 02:25:21PM +0200,

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-08 Thread Jiri Pirko
Mon, Jul 08, 2019 at 07:27:29PM CEST, mkube...@suse.cz wrote: >On Wed, Jul 03, 2019 at 10:41:51AM +0200, Jiri Pirko wrote: >> Tue, Jul 02, 2019 at 04:52:41PM CEST, mkube...@suse.cz wrote: >> >On Tue, Jul 02, 2019 at 02:25:21PM +0200, Jiri Pirko wrote: >> >> Tue, Jul 02, 2019 at 01:49:59PM CEST, mku

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-08 Thread Johannes Berg
On Mon, 2019-07-08 at 19:27 +0200, Michal Kubecek wrote: > > Second reason is that with 8-bit genetlink command/message id, the space > is not as infinite as it might seem. FWIW, there isn't really any good reason for this, we have like 16 reserved bits in the genl header. OTOH, having a LOT of

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-08 Thread Michal Kubecek
On Wed, Jul 03, 2019 at 10:41:51AM +0200, Jiri Pirko wrote: > Tue, Jul 02, 2019 at 04:52:41PM CEST, mkube...@suse.cz wrote: > >On Tue, Jul 02, 2019 at 02:25:21PM +0200, Jiri Pirko wrote: > >> Tue, Jul 02, 2019 at 01:49:59PM CEST, mkube...@suse.cz wrote: > >> >+ > >> >+ETHTOOL_A_HEADER_DEV_INDEX

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-03 Thread Jiri Pirko
Tue, Jul 02, 2019 at 04:52:41PM CEST, mkube...@suse.cz wrote: >On Tue, Jul 02, 2019 at 02:25:21PM +0200, Jiri Pirko wrote: >> Tue, Jul 02, 2019 at 01:49:59PM CEST, mkube...@suse.cz wrote: >> >+Request header >> >+-- >> >+ >> >+Each request or reply message contains a nested attribute wi

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-02 Thread Michal Kubecek
On Tue, Jul 02, 2019 at 06:29:56PM -0700, Jakub Kicinski wrote: > On Tue, 2 Jul 2019 13:49:59 +0200 (CEST), Michal Kubecek wrote: > > diff --git a/Documentation/networking/ethtool-netlink.txt > > b/Documentation/networking/ethtool-netlink.txt > > new file mode 100644 > > index ..97c36

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-02 Thread Jakub Kicinski
On Tue, 2 Jul 2019 13:49:59 +0200 (CEST), Michal Kubecek wrote: > diff --git a/Documentation/networking/ethtool-netlink.txt > b/Documentation/networking/ethtool-netlink.txt > new file mode 100644 > index ..97c369aa290b > --- /dev/null > +++ b/Documentation/networking/ethtool-netlink.t

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-02 Thread Michal Kubecek
On Tue, Jul 02, 2019 at 02:25:21PM +0200, Jiri Pirko wrote: > Tue, Jul 02, 2019 at 01:49:59PM CEST, mkube...@suse.cz wrote: > >+Request header > >+-- > >+ > >+Each request or reply message contains a nested attribute with common > >header. > >+Structure of this header is > > Missing "

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-02 Thread Jiri Pirko
Tue, Jul 02, 2019 at 01:49:59PM CEST, mkube...@suse.cz wrote: >Basic genetlink and init infrastructure for the netlink interface, register >genetlink family "ethtool". Add CONFIG_ETHTOOL_NETLINK Kconfig option to >make the build optional. Add initial overall interface description into >Documentatio

[PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-02 Thread Michal Kubecek
Basic genetlink and init infrastructure for the netlink interface, register genetlink family "ethtool". Add CONFIG_ETHTOOL_NETLINK Kconfig option to make the build optional. Add initial overall interface description into Documentation/networking/ethtool-netlink.txt, further patches will add more de