Re: [PATCH net-next v5 2/5] net: stmmac: introducing support for DWC xPCS logics

2019-06-03 Thread David Miller
From: Voon Weifeng Date: Sat, 1 Jun 2019 03:58:11 +0800 > +static void dw_xpcs_init(struct net_device *ndev, int pcs_mode) > +{ > + struct stmmac_priv *priv = netdev_priv(ndev); > + int xpcs_phy_addr = priv->plat->xpcs_phy_addr; > + int phydata; Reverse christmas tree please. Put t

[PATCH net-next v5 2/5] net: stmmac: introducing support for DWC xPCS logics

2019-05-31 Thread Voon Weifeng
From: Ong Boon Leong xPCS is DWC Ethernet Physical Coding Sublayer that may be integrated into a GbE controller that uses DWC EQoS MAC controller. An example of HW configuration is shown below:- <-GBE Controller-->|<--External PHY chip--> +--+ ++