Re: [PATCH net-next v4 8/9] xen-netback: Timeout packets in RX path

2014-01-20 Thread Zoltan Kiss
On 20/01/14 16:53, Wei Liu wrote: @@ -559,7 +579,7 @@ void xenvif_free(struct xenvif *vif) if (vif->grant_tx_handle[i] != NETBACK_INVALID_HANDLE) { unmap_timeout++; schedule_timeout(msecs_to_jiffies(1000)); - if

Re: [PATCH net-next v4 8/9] xen-netback: Timeout packets in RX path

2014-01-20 Thread Wei Liu
On Fri, Jan 17, 2014 at 07:27:35PM +, Zoltan Kiss wrote: > On 16/01/14 00:03, Wei Liu wrote: > >On Tue, Jan 14, 2014 at 08:39:54PM +, Zoltan Kiss wrote: > >[...] > >>diff --git a/drivers/net/xen-netback/common.h > >>b/drivers/net/xen-netback/common.h > >>index 109c29f..d1cd8ce 100644 > >>-

Re: [PATCH net-next v4 8/9] xen-netback: Timeout packets in RX path

2014-01-17 Thread Zoltan Kiss
On 16/01/14 00:03, Wei Liu wrote: On Tue, Jan 14, 2014 at 08:39:54PM +, Zoltan Kiss wrote: [...] diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 109c29f..d1cd8ce 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -12

Re: [PATCH net-next v4 8/9] xen-netback: Timeout packets in RX path

2014-01-15 Thread Wei Liu
On Tue, Jan 14, 2014 at 08:39:54PM +, Zoltan Kiss wrote: [...] > diff --git a/drivers/net/xen-netback/common.h > b/drivers/net/xen-netback/common.h > index 109c29f..d1cd8ce 100644 > --- a/drivers/net/xen-netback/common.h > +++ b/drivers/net/xen-netback/common.h > @@ -129,6 +129,9 @@ struct xen

[PATCH net-next v4 8/9] xen-netback: Timeout packets in RX path

2014-01-14 Thread Zoltan Kiss
A malicious or buggy guest can leave its queue filled indefinitely, in which case qdisc start to queue packets for that VIF. If those packets came from an another guest, it can block its slots and prevent shutdown. To avoid that, we make sure the queue is drained in every 10 seconds. The QDisc queu