RE: [PATCH net-next v4 5/5] net: stmmac: add EHL SGMII 1Gbps PCI info and PCI ID

2019-05-29 Thread Voon, Weifeng
> > > + plat->axi->axi_lpi_en = 0; > > + plat->axi->axi_xit_frm = 0; > > + plat->axi->axi_wr_osr_lmt = 0; > > This is not a valid value. Can you please explained why is not a valid value? And what should be the recommended value? Databook mentioned that "Maximum outstanding requests = WR_

RE: [PATCH net-next v4 5/5] net: stmmac: add EHL SGMII 1Gbps PCI info and PCI ID

2019-05-29 Thread Jose Abreu
From: Voon Weifeng Date: Wed, May 29, 2019 at 17:58:27 > + plat->axi = devm_kzalloc(&pdev->dev, sizeof(*plat->axi), > + GFP_KERNEL); > + if (!plat->axi) > + return -ENOMEM; Missing line break here. > + plat->axi->axi_lpi_en = 0; > + plat-

[PATCH net-next v4 5/5] net: stmmac: add EHL SGMII 1Gbps PCI info and PCI ID

2019-05-29 Thread Voon Weifeng
Added EHL SGMII 1Gbps PCI ID. Different MII and speed will have different PCI ID. Signed-off-by: Voon Weifeng --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 111 +++ 1 file changed, 111 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/dr