Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-08 Thread Tao Ren
On 8/8/19 3:11 PM, Heiner Kallweit wrote: > On 08.08.2019 23:47, Tao Ren wrote: >> Hi Heiner, >> >> On 8/7/19 9:24 PM, Tao Ren wrote: >>> Hi Heiner, >>> >>> On 8/7/19 12:18 PM, Heiner Kallweit wrote: On 06.08.2019 23:42, Tao Ren wrote: > Hi Andrew / Heiner / Vladimir, > > On 8/6/19

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-08 Thread Heiner Kallweit
On 08.08.2019 23:47, Tao Ren wrote: > Hi Heiner, > > On 8/7/19 9:24 PM, Tao Ren wrote: >> Hi Heiner, >> >> On 8/7/19 12:18 PM, Heiner Kallweit wrote: >>> On 06.08.2019 23:42, Tao Ren wrote: Hi Andrew / Heiner / Vladimir, On 8/6/19 2:09 PM, Tao Ren wrote: > The BCM54616S PHY cann

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-08 Thread Tao Ren
Hi Heiner, On 8/7/19 9:24 PM, Tao Ren wrote: > Hi Heiner, > > On 8/7/19 12:18 PM, Heiner Kallweit wrote: >> On 06.08.2019 23:42, Tao Ren wrote: >>> Hi Andrew / Heiner / Vladimir, >>> >>> On 8/6/19 2:09 PM, Tao Ren wrote: The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-07 Thread Tao Ren
Hi Heiner, On 8/7/19 12:18 PM, Heiner Kallweit wrote: > On 06.08.2019 23:42, Tao Ren wrote: >> Hi Andrew / Heiner / Vladimir, >> >> On 8/6/19 2:09 PM, Tao Ren wrote: >>> The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for >>> example, on Facebook CMM BMC platform), mainly becaus

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-07 Thread Heiner Kallweit
On 06.08.2019 23:42, Tao Ren wrote: > Hi Andrew / Heiner / Vladimir, > > On 8/6/19 2:09 PM, Tao Ren wrote: >> The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for >> example, on Facebook CMM BMC platform), mainly because genphy functions >> are designed for copper links, and 1000

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-06 Thread Tao Ren
On 8/6/19 3:00 PM, Heiner Kallweit wrote: > On 06.08.2019 23:09, Tao Ren wrote: >> The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for >> example, on Facebook CMM BMC platform), mainly because genphy functions >> are designed for copper links, and 1000Base-X (clause 37) auto nego

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-06 Thread Heiner Kallweit
On 06.08.2019 23:09, Tao Ren wrote: > The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for > example, on Facebook CMM BMC platform), mainly because genphy functions > are designed for copper links, and 1000Base-X (clause 37) auto negotiation > needs to be handled differently. > >

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-06 Thread Tao Ren
Hi Andrew / Heiner / Vladimir, On 8/6/19 2:09 PM, Tao Ren wrote: > The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for > example, on Facebook CMM BMC platform), mainly because genphy functions > are designed for copper links, and 1000Base-X (clause 37) auto negotiation > needs t

[PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-06 Thread Tao Ren
The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for example, on Facebook CMM BMC platform), mainly because genphy functions are designed for copper links, and 1000Base-X (clause 37) auto negotiation needs to be handled differently. This patch enables 1000Base-X support for BCM54