Re: [PATCH net-next v4 1/2]L2TP:Adjust intf MTU, add underlay L3, L2 hdrs

2017-03-20 Thread R. Parameswaran
Hi James, Thanks for the response and suggestions, please see inline: On Mon, 20 Mar 2017, James Chapman wrote: > The patch comment of each patch should represent the changes of the > patch. You seem to be using a common description for your two commits > and this will look out of place when v

Re: [PATCH net-next v4 1/2]L2TP:Adjust intf MTU, add underlay L3, L2 hdrs

2017-03-20 Thread James Chapman
The patch comment of each patch should represent the changes of the patch. You seem to be using a common description for your two commits and this will look out of place when viewed using git log on one of the files modified by this patch. The patch summary line here is also inaccurate. Are you us

[PATCH net-next v4 1/2]L2TP:Adjust intf MTU, add underlay L3, L2 hdrs

2017-03-17 Thread R. Parameswaran
In existing kernel code, when setting up the L2TP interface, all of the tunnel encapsulation headers are not taken into account when setting up the MTU on the L2TP logical interface device. Due to this, the packets created by the applications on top of the L2TP layer are larger than they ought to