[PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-22 Thread Dan Murphy
Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ti,d

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Andrew On 5/20/20 3:44 PM, Andrew Lunn wrote: I think adding it in the core would be a bit of a challenge.  I think each PHY driver needs to handle parsing and validating this property on its own (like fifo-depth).  It is a PHY specific setting. fifo-depth yes. But some delays follow a common p

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Andrew Lunn
> I think adding it in the core would be a bit of a challenge.  I think each > PHY driver needs to handle parsing and validating this property on its own > (like fifo-depth).  It is a PHY specific setting. fifo-depth yes. But some delays follow a common pattern. e.g. Documentation/devicetree/bind

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Andrew On 5/20/20 2:27 PM, Andrew Lunn wrote: Hi Dan UGH I think I just got volunteered to do make them common. There is code you can copy from PHY drivers. :-) What would be kind of nice is if the validate was in the core as well. Pass a list of possible delays in pS, and it will do a phyde

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Andrew Lunn
Hi Dan > UGH I think I just got volunteered to do make them common. There is code you can copy from PHY drivers. :-) What would be kind of nice is if the validate was in the core as well. Pass a list of possible delays in pS, and it will do a phydev_err() if what is in DT does not match one of t

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Florian On 5/20/20 12:45 PM, Florian Fainelli wrote: On 5/20/2020 10:20 AM, Dan Murphy wrote: Andrew/Florian On 5/20/20 11:43 AM, Andrew Lunn wrote: I am interested in knowing where that is documented.  I want to RTM I grepped for a few different words but came up empty Hi Dan It probably

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Florian Fainelli
On 5/20/2020 10:20 AM, Dan Murphy wrote: > Andrew/Florian > > On 5/20/20 11:43 AM, Andrew Lunn wrote: >>> I am interested in knowing where that is documented.  I want to RTM I >>> grepped for a few different words but came up empty >> Hi Dan >> >> It probably is not well documented, but one exa

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Andrew/Florian On 5/20/20 11:43 AM, Andrew Lunn wrote: I am interested in knowing where that is documented.  I want to RTM I grepped for a few different words but came up empty Hi Dan It probably is not well documented, but one example would be Documentation/devicetree/bindings/net/ethernet-c

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Andrew Lunn
> I am interested in knowing where that is documented.  I want to RTM I > grepped for a few different words but came up empty Hi Dan It probably is not well documented, but one example would be Documentation/devicetree/bindings/net/ethernet-controller.yaml says: # RX and TX delays are ad

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Florian Fainelli
On 5/20/2020 8:56 AM, Dan Murphy wrote: > Andrew > > On 5/20/20 10:36 AM, Andrew Lunn wrote: Hi Dan Having it required with PHY_INTERFACE_MODE_RGMII_ID or PHY_INTERFACE_MODE_RGMII_RXID is pretty unusual. Normally these properties are used to fine tune the delay, if the

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Andrew On 5/20/20 10:36 AM, Andrew Lunn wrote: Hi Dan Having it required with PHY_INTERFACE_MODE_RGMII_ID or PHY_INTERFACE_MODE_RGMII_RXID is pretty unusual. Normally these properties are used to fine tune the delay, if the default of 2ns does not work. Also if the MAC phy-mode is configured w

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Andrew Lunn
> > Hi Dan > > > > Having it required with PHY_INTERFACE_MODE_RGMII_ID or > > PHY_INTERFACE_MODE_RGMII_RXID is pretty unusual. Normally these > > properties are used to fine tune the delay, if the default of 2ns does > > not work. > > Also if the MAC phy-mode is configured with RGMII-ID and no in

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Andrew On 5/20/20 10:28 AM, Dan Murphy wrote: Andrew On 5/20/20 8:56 AM, Andrew Lunn wrote: On Wed, May 20, 2020 at 07:18:34AM -0500, Dan Murphy wrote: Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy ---   ..

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Andrew On 5/20/20 8:56 AM, Andrew Lunn wrote: On Wed, May 20, 2020 at 07:18:34AM -0500, Dan Murphy wrote: Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml| 1

Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Andrew Lunn
On Wed, May 20, 2020 at 07:18:34AM -0500, Dan Murphy wrote: > Add the internal delay values into the header and update the binding > with the internal delay properties. > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83869.yaml| 16 > include/dt-bindin

[PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-20 Thread Dan Murphy
Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml| 16 include/dt-bindings/net/ti-dp83869.h | 18 ++ 2 files changed, 34