Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-29 Thread Ding Tianhong
On 2013/12/30 14:05, Joe Perches wrote: > On Mon, 2013-12-30 at 10:39 +0800, Ding Tianhong wrote: >> I don't understand packetengine NIC anymore, But I think the change is >> clearly, >> as your said, the broadcast check is enough here, did you mean that? >> >> !is_broadcast_ether_addr((u8 *)

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-29 Thread Joe Perches
On Mon, 2013-12-30 at 10:39 +0800, Ding Tianhong wrote: > I don't understand packetengine NIC anymore, But I think the change is > clearly, > as your said, the broadcast check is enough here, did you mean that? > > !is_broadcast_ether_addr((u8 *)(le32_to_cpu(yp->rx_ring_dma) + >

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-29 Thread Ding Tianhong
On 2013/12/29 1:23, Joe Perches wrote: > On Sat, 2013-12-28 at 23:18 +0800, Ding Tianhong wrote: >> 于 2013/12/28 21:58, Sergei Shtylyov 写道: >>> Hello. >>> >>> On 28-12-2013 10:17, Ding Tianhong wrote: >>> Use possibly more efficient ether_addr_equal to instead of memcmp. >>> Cc: "Dav

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-28 Thread Sergei Shtylyov
Hello. On 12/28/2013 06:18 PM, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: "David S. Miller" Signed-off-by: Ding Tianhong --- drivers/net/ethernet/packetengines/yellowfin.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletio

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-28 Thread Joe Perches
On Sat, 2013-12-28 at 23:18 +0800, Ding Tianhong wrote: > 于 2013/12/28 21:58, Sergei Shtylyov 写道: > > Hello. > > > > On 28-12-2013 10:17, Ding Tianhong wrote: > > > >> Use possibly more efficient ether_addr_equal > >> to instead of memcmp. > > > >> Cc: "David S. Miller" > >> Signed-off-by: Ding

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-28 Thread Ding Tianhong
于 2013/12/28 21:58, Sergei Shtylyov 写道: > Hello. > > On 28-12-2013 10:17, Ding Tianhong wrote: > >> Use possibly more efficient ether_addr_equal >> to instead of memcmp. > >> Cc: "David S. Miller" >> Signed-off-by: Ding Tianhong >> --- >> drivers/net/ethernet/packetengines/yellowfin.c | 12

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-28 Thread Sergei Shtylyov
Hello. On 28-12-2013 10:17, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: "David S. Miller" Signed-off-by: Ding Tianhong --- drivers/net/ethernet/packetengines/yellowfin.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-)

[PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-27 Thread Ding Tianhong
Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: "David S. Miller" Signed-off-by: Ding Tianhong --- drivers/net/ethernet/packetengines/yellowfin.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/packetengines/yellowf